Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spec-filter): allow custom specFilter #290

Merged
merged 1 commit into from
Jun 16, 2022
Merged

feat(spec-filter): allow custom specFilter #290

merged 1 commit into from
Jun 16, 2022

Conversation

nicojs
Copy link
Contributor

@nicojs nicojs commented Jul 3, 2021 •
edited
Loading

Allow users to define their own jasmine specFilter.

jasmine.getEnv().configure({
  specFilter: function(spec) {
    // ...
  }
})

Fixes #273

@nicojs
Copy link
Contributor Author

nicojs commented Jul 3, 2021

@johnjbarton It has been more than a year, but here it is 😅

@nicojs
Copy link
Contributor Author

nicojs commented Nov 21, 2021

@johnjbarton do you think you can find time to take a look at this? It's an important feature for StrykerJS users

@nicojs nicojs mentioned this pull request Jan 13, 2022
Merged
5 tasks
@nicojs
Copy link
Contributor Author

nicojs commented Apr 12, 2022

@jginsburgn would you please be so kind to review this PR? It is actually breaking StrykerJS for karma-jasmine users (they experience false negatives on timeouts)

@jginsburgn
Copy link
Member

@jginsburgn would you please be so kind to review this PR? It is actually breaking StrykerJS for karma-jasmine users (they experience false negatives on timeouts)

Surely. Please resolve the conflicts!

@nicojs nicojs force-pushed the feat/custom-spec-filter branch from 06e28f6 to 63f4649 Compare April 13, 2022 06:18
@nicojs
Copy link
Contributor Author

nicojs commented Apr 13, 2022

@jginsburgn thanks in advance! Just resolved the conflicts

devoto13
devoto13 previously approved these changes Apr 24, 2022
View reviewed changes
Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry that it took so long to review!

@devoto13 devoto13 requested a review from jginsburgn April 24, 2022 10:24
@jginsburgn jginsburgn force-pushed the feat/custom-spec-filter branch from 63f4649 to a2f7626 Compare April 25, 2022 03:04
jginsburgn
jginsburgn requested changes Apr 25, 2022
View reviewed changes
Copy link
Member

@jginsburgn jginsburgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicojs can you add some documentation in the README file?

@nicojs
Copy link
Contributor Author

nicojs commented May 29, 2022

@jginsburgn sorry I didn't catch that 2 months ago. Added a remark in the readme 📖

@nicojs
feat(spec-filter): allow custom specFilter
e416b1c 
Allow users to define their own jasmine `specFilter`.

```js
jasmine.getEnv().configure({
  specFilter: function(spec) {
    // ...
  }
})
```
@nicojs nicojs force-pushed the feat/custom-spec-filter branch from 424ca6a to e416b1c Compare May 29, 2022 09:23
@nicojs nicojs mentioned this pull request May 29, 2022
Merged
1 task
@jginsburgn jginsburgn merged commit b73dbd6 into karma-runner:master Jun 16, 2022
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nicojs
Copy link
Contributor Author

nicojs commented Jun 16, 2022

Thanks @jginsburgn 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jginsburgn jginsburgn jginsburgn approved these changes

@devoto13 devoto13 devoto13 left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set custom jasmine specFilter
4 participants
@nicojs @jginsburgn @karmarunnerbot @devoto13