Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flexible output name #94

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

mdecleir
Copy link
Collaborator

@mdecleir mdecleir commented Dec 1, 2021

Small PR to make the naming of the average extinction curve a little more flexible.
This is to make the script compatible with scripts in the spex_nir_extinction repo.

@codecov-commenter
Copy link

Codecov Report

Merging #94 (7f3486e) into master (520751a) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   46.37%   46.45%   +0.07%     
==========================================
  Files          19       19              
  Lines        2536     2536              
==========================================
+ Hits         1176     1178       +2     
+ Misses       1360     1358       -2     
Impacted Files Coverage Δ
measure_extinction/utils/calc_ext.py 71.42% <100.00%> (ø)
measure_extinction/extdata.py 64.09% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520751a...7f3486e. Read the comment docs.

Copy link
Owner

@karllark karllark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome update. Especially the docs!

@karllark karllark merged commit 95cbdb9 into karllark:master Dec 2, 2021
@mdecleir mdecleir deleted the flex_names branch December 22, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants