Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STIS LSFs used in mocking of spectra #86

Merged
merged 5 commits into from
Sep 17, 2021
Merged

STIS LSFs used in mocking of spectra #86

merged 5 commits into from
Sep 17, 2021

Conversation

karllark
Copy link
Owner

STIS mocking using stellar atmosphere models now uses the provide STIS line spread functions (instead of an approximate Gaussian).

@karllark karllark added the enhancement New feature or request label Aug 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #86 (ebc0446) into master (d88e8e8) will decrease coverage by 1.31%.
The diff coverage is 10.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   47.47%   46.15%   -1.32%     
==========================================
  Files          18       19       +1     
  Lines        2435     2526      +91     
==========================================
+ Hits         1156     1166      +10     
- Misses       1279     1360      +81     
Impacted Files Coverage Δ
measure_extinction/merge_obsspec.py 6.80% <0.00%> (ø)
measure_extinction/utils/mock_spectra_data.py 10.10% <10.10%> (ø)
...easure_extinction/utils/make_obsdata_from_model.py 11.72% <22.22%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88e8e8...ebc0446. Read the comment docs.

@karllark
Copy link
Owner Author

karllark commented Sep 7, 2021

STIS line-spread-functions.

stis_lsfs

@karllark
Copy link
Owner Author

karllark commented Sep 7, 2021

Impact on on model spectra. Black R=5000 spectra. Blue = STIS mocked spectra with line-spread-functions. Red = simple R=1000 Gaussian mocking of spectra (how the mocking was done before this PR).

mock_stis_obs

@karllark karllark merged commit f4d0b6f into master Sep 17, 2021
@karllark karllark deleted the stis_lsfs branch November 24, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants