Plot tweaks

[mdecleir]

This PR contains several changes to the plotting of spectra and extinction curves:

• Changed default plotting settings
• Added option to exclude certain bands from plotting instead of all bands or no bands

Other changes:

• Quadratically added 1 percent uncertainty to the SpeX spectra
• Small updates to masked windows of SpeX spectra

Some changes will be in conflict with the latest merge from PR #66 , so we will have to fix the conflicts first.

[mdecleir]

For some reason, it is only doing 1 test. Where did all the other tests go?

[mdecleir]

Looking at the conflicts, I don't really understand why they are indicated as conflicts. They are different keywords that we added separately, but these are independent from each other. We want to keep both keywords. How can we fix this?

[karllark]

Looking at the conflicts, I don't really understand why they are indicated as conflicts. They are different keywords that we added separately, but these are independent from each other. We want to keep both keywords. How can we fix this?

The automated routine can't decide if the changes are in conflict or not. They are in the same place in the code and have different names. Hence it is kicking this back to the humans. The solution is to rebase and manually include both changes.

[karllark]

For some reason, it is only doing 1 test. Where did all the other tests go?

Only one test in being run as there are merge conflicts, hence it cannot run any of the other tests.

[mdecleir]

I merged the changes. This should solve the conflicts.

[mdecleir]

I clearly broke the code by merging the changes. I will try to fix this.

[karllark]

I clearly broke the code by merging the changes. I will try to fix this.

Been there. Did this last week. ;-)

[codecov-commenter]

Codecov Report

Merging #82 (58bd5cc) into master (be30c2e) will increase coverage by 0.50%.
The diff coverage is 62.85%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   46.50%   47.00%   +0.50%     
==========================================
  Files          18       18              
  Lines        2415     2436      +21     
==========================================
+ Hits         1123     1145      +22     
+ Misses       1292     1291       -1     

Impacted Files	Coverage Δ
measure_extinction/merge_obsspec.py	6.80% <0.00%> (-0.05%)	⬇️
measure_extinction/utils/merge_spex_spec.py	24.32% <ø> (ø)
measure_extinction/extdata.py	60.72% <66.66%> (+0.03%)	⬆️
measure_extinction/stardata.py	75.99% <66.66%> (+1.49%)	⬆️
measure_extinction/plotting/plot_ext.py	75.00% <75.00%> (+0.21%)	⬆️
measure_extinction/plotting/plot_spec.py	75.56% <75.00%> (-0.02%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be30c2e...58bd5cc. Read the comment docs.

[mdecleir]

Issues have been fixed. Tests are successful now. This PR is ready to be reviewed.

[karllark]

Looks good to me.