Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general: switch HPI to src/ layout #316

Closed
karlicoss opened this issue Oct 5, 2023 · 2 comments
Closed

general: switch HPI to src/ layout #316

karlicoss opened this issue Oct 5, 2023 · 2 comments

Comments

@karlicoss
Copy link
Owner

I'm thinking that would be nice to switch to src/ layout for consistency (and generally it tends to have less gotchas).
Should be smooth, the only concern is that it will break existing editable installations (since egg link would be pointing to /path/to/hpi_repo rather than /path/to/hpi_repo/src), unless the user reinstalls it.
I think that should be solvable just by putting a symlink from my to src/my though, and could add a warning suggesting the user to reinstall. Not sure if there are any other issues?
cc @seanbreckenridge

@purarue
Copy link
Contributor

purarue commented Oct 5, 2023

Yeah seems fine

One would need to git pull to update an editable install anyways, so they'd probably notice that

Will probably swap the HPI-template and my repo as well just for the consistency

@karlicoss karlicoss changed the title switch HPI to src/ layout general: switch HPI to src/ layout Oct 19, 2024
@karlicoss
Copy link
Owner Author

Been experimenting more with editable installs etc, and seems like src/ layout works better in that case as well, it creates a simple .pth file in site-packages with a path to src/ dir, instead of dynamic __editable*.py madness, in particular this means less issues for running mypy with editable install python/mypy#13392 (comment)

So going to finally switch it soon

karlicoss added a commit that referenced this issue Jan 23, 2025
this is long overdue and much friendlier to python tooling ecosystem

should be backwards compatible with existing editable installs, with a warning to reinstall properly

see #316
karlicoss added a commit that referenced this issue Jan 23, 2025
this is long overdue and much friendlier to python tooling ecosystem

should be backwards compatible with existing editable installs, with a warning to reinstall properly

see #316
karlicoss added a commit that referenced this issue Jan 24, 2025
this is long overdue and much friendlier to python tooling ecosystem

should be backwards compatible with existing editable installs, with a warning to reinstall properly

see #316
karlicoss added a commit that referenced this issue Jan 24, 2025
this is long overdue and much friendlier to python tooling ecosystem

should be backwards compatible with existing editable installs, with a warning to reinstall properly

see #316
karlicoss added a commit that referenced this issue Jan 24, 2025
this is long overdue and much friendlier to python tooling ecosystem

should be backwards compatible with existing editable installs, with a warning to reinstall properly

see #316
karlicoss added a commit that referenced this issue Jan 24, 2025
this is long overdue and much friendlier to python tooling ecosystem

should be backwards compatible with existing editable installs, with a warning to reinstall properly

see #316
karlicoss added a commit that referenced this issue Jan 24, 2025
this is long overdue and much friendlier to python tooling ecosystem

should be backwards compatible with existing editable installs, with a warning to reinstall properly

see #316
karlicoss added a commit that referenced this issue Jan 24, 2025
this is long overdue and much friendlier to python tooling ecosystem

should be backwards compatible with existing editable installs, with a warning to reinstall properly

see #316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants