Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better embed builders #15

Merged
merged 1 commit into from
Jan 6, 2022
Merged

better embed builders #15

merged 1 commit into from
Jan 6, 2022

Conversation

karitham
Copy link
Owner

@karitham karitham commented Jan 6, 2022

fixes #11

@karitham karitham mentioned this pull request Jan 6, 2022
Merged
@jolheiser
Copy link
Collaborator

jolheiser commented Jan 6, 2022 •
edited
Loading

Do we even need "builders"?
The embed/resp structs can just return themselves, which is effectively a builder.

Ack, forgot that would mean overlapping fields.

@karitham
Copy link
Owner Author

karitham commented Jan 6, 2022

Do we even need "builders"? The embed/resp structs can just return themselves, which is effectively a builder.

Ack, forgot that would mean overlapping fields.

Exactly what I told myself, so I deleted my builders, and names were overlapping.
Honestly the builders aren't an amazing solution, but I don't think there's a better way to make it look clean on the user's end

@karitham karitham merged commit 2c50c82 into master Jan 6, 2022
@karitham karitham deleted the feat/better-builders branch January 6, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Builders
2 participants
@karitham @jolheiser