Bump react-dom and @types/react-dom in /frontend (nucleuscloud#2036)

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nick Z <[email protected]>
karimalzalek · May 29, 2024 · 8cfdb19 · 8cfdb19
1 parent 9965b9f
commit 8cfdb19
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 51 deletions.
diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml
@@ -17,6 +17,10 @@ jobs:
 
       - name: Set up Node
         uses: actions/setup-node@v4
+        with:
+          node-version: lts/*
+          cache: npm
+          cache-dependency-path: ./frontend/package-lock.json
 
       - run: npm install
       - run: npm run knip:production
@@ -33,20 +37,10 @@ jobs:
 
       - name: Set up Node
         uses: actions/setup-node@v4
-
-      - name: Cache node modules
-        id: cache-npm
-        uses: actions/cache@v4
-        env:
-          cache-name: prettier-node-modules
         with:
-          # npm cache files are stored in `~/.npm` on Linux/macOS
-          path: ~/.npm
-          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-build-${{ env.cache-name }}-
-            ${{ runner.os }}-build-
-            ${{ runner.os }}-
+          node-version: lts/*
+          cache: npm
+          cache-dependency-path: ./frontend/package-lock.json
 
       - run: npm install
       - run: npm run prettier:check
@@ -63,19 +57,13 @@ jobs:
 
       - name: Set up Node
         uses: actions/setup-node@v4
-
-      - name: Cache node modules
-        id: cache-npm
-        uses: actions/cache@v4
         with:
-          # npm cache files are stored in `~/.npm` on Linux/macOS
-          path: |
-            ~/.npm
-            ${{ github.workspace }}/.next/cache
-          key: ${{ runner.os }}-nextjs-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }}
-          restore-keys: |
-            ${{ runner.os }}-nextjs-${{ hashFiles('**/package-lock.json') }}-
+          node-version: lts/*
+          cache: npm
+          cache-dependency-path: ./frontend/package-lock.json
 
       - run: npm install
       - name: Build
         run: npm run build
+        env:
+          NODE_ENV: production
diff --git a/docker/Dockerfile.frontend b/docker/Dockerfile.frontend
@@ -1,4 +1,4 @@
-FROM node:18-alpine AS base
+FROM node:20-alpine AS base
 
 # This Dockerfile is copy-pasted into our main docs at /docs/handbook/deploying-with-docker.
 # Make sure you update both files!

diff --git a/frontend/apps/web/dev/build/Dockerfile.dev b/frontend/apps/web/dev/build/Dockerfile.dev
@@ -1,4 +1,4 @@
-FROM node:18-alpine
+FROM node:20-alpine
 
 WORKDIR /app
 

diff --git a/frontend/apps/web/package.json b/frontend/apps/web/package.json
@@ -56,9 +56,9 @@
     "next-auth": "^5.0.0-beta.4",
     "next-themes": "^0.2.1",
     "posthog-js": "^1.128.3",
-    "react": "18.2.0",
+    "react": "18.3.1",
     "react-day-picker": "^8.10.1",
-    "react-dom": "18.2.0",
+    "react-dom": "18.3.1",
     "react-hook-form": "^7.51.5",
     "react-hook-form-persist": "^3.0.0",
     "react-icons": "^5.2.1",
@@ -72,8 +72,8 @@
   },
   "devDependencies": {
     "@types/node": "20.12.12",
-    "@types/react": "18.2.79",
-    "@types/react-dom": "18.2.25",
+    "@types/react": "18.3.3",
+    "@types/react-dom": "18.3.0",
     "@types/react-window": "^1.8.8",
     "@typescript-eslint/eslint-plugin": "^7.11.0",
     "@typescript-eslint/parser": "^7.11.0",

diff --git a/frontend/package-lock.json b/frontend/package-lock.json