Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is undesirable to keep the task launch operation as a synchronous side-effect of
RunOutput#init
, since:RunOutput
inappropriate to initialise on a Cocoa app's main thread.In this PR,
RunOutput
's initialiser has been turned 'dumb', all mutation eliminated, and the task launch operation relocated toAsyncCommand#launch(complete: @escaping (RunOutput) -> Void))
.Further points:
CommandRunning#run(_ executable...)
, which usesAsyncCommand
, remains synchronous and waits for#launch
to complete, taking on issue 2 above.AsyncCommand#launch
is a standard asynchronous method, so it makes the presence ofPrintedAsyncCommand#onCompletion
, which is a completion handler setter, a little awkward.