Adding support for adding gatling session variables into karate features. #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-rao
commented
May 23, 2021
Comment on lines
88
to
91
| if (arg.containsKey(KarateAction.KARATE_CONTEXT_SESSION_KEY)) { | ||
| // unwrapping karate attributes and removing it from attribs. | ||
| val karateAttribs = arg.remove("__karate").asInstanceOf[scala.collection.mutable.Map[String, AnyRef]].asJava | ||
| val karateAttribs = arg.remove(KarateAction.KARATE_CONTEXT_SESSION_KEY).asInstanceOf[Map[String, AnyRef]].asJava | ||
| arg.putAll(karateAttribs) |
There was a problem hiding this comment.
Intentionally moved away from mutable map, in favour of immutable map.
abhi-rao
commented
May 23, 2021
| object PreDef { | ||
| def karateProtocol(uriPatterns: (String, Seq[MethodPause])*) = new KarateProtocol(uriPatterns.toMap) | ||
| def karateFeature(name: String, tags: String *) = new KarateActionBuilder(name, tags) | ||
| def karateAdd(key: String, valueSupplier: Session => AnyRef ) = new KarateContextAddBuilder(key, valueSupplier) |
There was a problem hiding this comment.
@ptrthomas Any suggestions on the name?
added 2 commits
May 23, 2021 14:51
|
thanks for this. it may be easier for me to refactor after merge. I'd like to see if we can merge the 2 simulations we have since it adds to the CI time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, while using karate-gatling, there is no way to pass variables from gatling onto karate.
By adding an action
karateAdd, the data from gatling can be passed onto karate features.Without this,
__karateneeds to manipulate, but this abstraction would help in keeping avoiding dependence on internals.