Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow "match contains" with empty expectations object to be true #1401

Merged
merged 1 commit into from
Dec 16, 2020
Merged

allow "match contains" with empty expectations object to be true #1401

merged 1 commit into from
Dec 16, 2020

Conversation

ivangsa
Copy link
Contributor

@ivangsa ivangsa commented Dec 15, 2020 •
edited
Loading

Description

allow "match contains" with empty expectations object to be true

* def foo = { bar: 1, baz: 'hello', ban: 'world' }
# both match will be true
* match foo contains { bar: 1 }
* match foo contains {}
  • Relevant Issues : (compulsory)
  • Relevant PRs : (optional)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

allow "match contains" with empty expectations object to be true
e1ffc60 
* def foo = { bar: 1, baz: 'hello', ban: 'world' }
# this will be true
* match foo contains {}
@ptrthomas ptrthomas merged commit 2f739a2 into karatelabs:develop Dec 16, 2020
ptrthomas added a commit that referenced this pull request Dec 16, 2020
@ptrthomas
added tests and tweak for #1401
b376636
@ivangsa ivangsa deleted the features/matchContainsEmpty branch December 16, 2020 09:14
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivangsa @ptrthomas