Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check current password functionality improvement request #7

Closed
yuriw opened this issue Apr 26, 2020 · 5 comments
Closed

Check current password functionality improvement request #7

yuriw opened this issue Apr 26, 2020 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@yuriw
Copy link

yuriw commented Apr 26, 2020

When I do Check all passwords I get:

image

But when I do Check current password I actually see nothing?
Ref: #6 (comment)

I think Check current password should behave like https://haveibeenpwned.com/Passwords
For example, if a user wants to verify password 12345, the website comes back with message:
image

I suspect that novice users won't even know what the plugin does without such functionality.

@yuriw yuriw changed the title Check current password functionality Check current password functionality improvement request Apr 26, 2020
@kapsiR
Copy link
Owner

kapsiR commented Apr 26, 2020

Just to clarify, when you check a single entry, you only get a message, if the entry has been pwned.
From the readme Check the current selected entry:
check single entry

So is your intention that you always get a message, even if the password is ok?

@kapsiR kapsiR added the needs more info The issue is not actionable yet, more details are needed label Apr 26, 2020
@yuriw
Copy link
Author

yuriw commented Apr 27, 2020

@kapsiR Yes I think when a single entry id checked in any case a message should be shown

@kapsiR kapsiR added enhancement New feature or request and removed needs more info The issue is not actionable yet, more details are needed labels Apr 27, 2020
@kapsiR
Copy link
Owner

kapsiR commented Apr 27, 2020

Thanks for clarification. I'll consider it for the next release 😉

@kapsiR kapsiR added this to the v0.6.0 milestone Apr 27, 2020
kapsiR added a commit that referenced this issue Apr 30, 2020
@kapsiR kapsiR closed this as completed in 1a8a048 May 1, 2020
@kapsiR
Copy link
Owner

kapsiR commented May 1, 2020

@yuriw You can try it out directly with the current v0.6.0-preview version 😉

@yuriw
Copy link
Author

yuriw commented May 1, 2020

@kapsiR works great thx for quick implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants