Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Range Component Prototype #1

Draft
wants to merge 13 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

kangzj
Copy link
Owner

@kangzj kangzj commented Sep 3, 2024

This is a WIP and not yet applied any design

PT: pejTkB-1zd-p2

What?

  • Refactor Day component into a separate file to be reused
  • Created a DateRange component that works for a date range selection, which is still mostly a copy of the date picker
  • Create base stories for DateRange

Why?

Add a date range picker

Testing Instructions

  • Checkout my fork
  • Choose the right node version nvm use
  • Install npm i
  • Run storybook npm run storybook:dev
  • Search for DateRange
  • Ensure the third example marks several dates as selected

Testing Instructions for Keyboard

n/a

Screenshots or screencast

Screen.Recording.2024-09-05.at.4.17.48.PM.mov

@kangzj kangzj self-assigned this Sep 3, 2024
@kangzj kangzj changed the base branch from feature/date-range-component to trunk September 3, 2024 00:04
@kangzj kangzj requested a review from annacmc September 3, 2024 02:52
@kangzj kangzj changed the title Stats: Add date range component Date Range Component Prototype Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant