Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubert-discrete symbol-based HiFiGAN with duration predictor #388

Merged
merged 27 commits into from
Feb 6, 2023

Conversation

ftshijt
Copy link
Contributor

@ftshijt ftshijt commented Jan 22, 2023

  • major functions/code necessary for training
  • recipe for cvss_c
  • inference scripts for cvss_c with duration predictor

(I also apply isort to follow the style in ESPnet, please let me know if this is not needed for some reason)

@kan-bayashi
Copy link
Owner

Thanks, @ftshijt

(I also apply isort to follow the style in ESPnet, please let me know if this is not needed for some reason)

To make this PR's contribution clear, I will make another PR to apply isort.
Please wait for a while.

@kan-bayashi
Copy link
Owner

I applied isort to master. Please merge it.

@ftshijt
Copy link
Contributor Author

ftshijt commented Jan 26, 2023

Hi @kan-bayashi , may I ask for your help on the CI test? I'm not quite sure why the CI failed for the import as I'm basically following the same way as other losses.

parallel_wavegan/losses/__init__.py:2:1: F403 'from .duration_prediction_loss import *' used; unable to detect undefined names
parallel_wavegan/losses/__init__.py:2:1: F401 '.duration_prediction_loss.*' imported but unused

@kan-bayashi
Copy link
Owner

kan-bayashi commented Jan 26, 2023

I'm not quite sure why

Maybe due to simple typo lol

@ftshijt ftshijt changed the title [WIP] Hubert-discrete symbol-based HiFiGAN with duration predictor Hubert-discrete symbol-based HiFiGAN with duration predictor Jan 30, 2023
@ftshijt
Copy link
Contributor Author

ftshijt commented Jan 30, 2023

I think this PR is ready. Please let me know if you have any suggestions or comments~ many thanks!

@ftshijt
Copy link
Contributor Author

ftshijt commented Jan 30, 2023

Maybe I can also put some pre-trained models into the readme?

Copy link
Owner

@kan-bayashi kan-bayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a great extension, @ftshijt.
I slightly modified your code to remove duplicated part or comments.

@kan-bayashi
Copy link
Owner

Maybe I can also put some pre-trained models into the readme?

That is great. Please open a new PR when the model is ready.

@kan-bayashi
Copy link
Owner

If you have a time, adding a test for the hifigan with duration prediction is preferable.
Anyway, I will merge this PR at first :) Thank you again, @ftshijt.

@kan-bayashi kan-bayashi merged commit ee7e4ec into kan-bayashi:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants