-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hubert-discrete symbol-based HiFiGAN with duration predictor #388
Conversation
Thanks, @ftshijt
To make this PR's contribution clear, I will make another PR to apply isort. |
I applied isort to master. Please merge it. |
Hi @kan-bayashi , may I ask for your help on the CI test? I'm not quite sure why the CI failed for the import as I'm basically following the same way as other losses.
|
Maybe due to simple typo lol |
Co-authored-by: Tomoki Hayashi <[email protected]>
I think this PR is ready. Please let me know if you have any suggestions or comments~ many thanks! |
Maybe I can also put some pre-trained models into the readme? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a great extension, @ftshijt.
I slightly modified your code to remove duplicated part or comments.
That is great. Please open a new PR when the model is ready. |
If you have a time, adding a test for the hifigan with duration prediction is preferable. |
(I also apply isort to follow the style in ESPnet, please let me know if this is not needed for some reason)