Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows word as misspelled after SpelunkerAdd, doesn't only after editor restart #35

Closed
rasuru opened this issue Apr 18, 2020 · 14 comments · Fixed by #42
Closed

Shows word as misspelled after SpelunkerAdd, doesn't only after editor restart #35

rasuru opened this issue Apr 18, 2020 · 14 comments · Fixed by #42

Comments

@rasuru
Copy link

rasuru commented Apr 18, 2020

No description provided.

@kamykn
Copy link
Owner

kamykn commented Apr 20, 2020

@rasuru
Sorry, I'm trying to find out this problem, but same problem does not occur with my Vim. Can you tell me your situation when the problem occurred.

  1. Please tell me your spelunker.vim settings.
  2. Does the problem occur with a specific words?

I need more information to replicate the same behavior you reported.

@kamykn
Copy link
Owner

kamykn commented Apr 20, 2020

I fix some bugs, maybe it's been fixed.
Please update the plugin and make sure the problem is fixed.

9bfe895
d0f892a

@rasuru
Copy link
Author

rasuru commented Apr 20, 2020

@kamykn
Thank you for your fast reply! Here is everything connected to spelunker in my init.vim:

Plug 'kamykn/spelunker.vim', { 'commit': 'd0f892a' } " spell checking
" spelunker
let g:enable_spelunker_vim_on_readonly = 1
let g:spelunker_check_type = 1
let g:spelunker_highlight_type = 2
set nospell " instead use spelunker

The behavior is the same when I just add a single word with zg (tried Zg, zw, Zw too). Vim just prints Word 'autocomplete' added to ~/.config/nvim/spell/en.utf-8.add to cmd. Maybe I need to tweak some native Vim settings?

@kamykn
Copy link
Owner

kamykn commented Apr 23, 2020

@rasuru
Thank you for sharing your settings, I was able to reproduce this bug.
I found out there are matchdelete() bug with nvim.
neovim/neovim#12110

I've added code to spelunker.vim to resolve this bug.
Please try updating spelunker.vim plugin.

@rasuru
Copy link
Author

rasuru commented Apr 23, 2020

Unfortunatly, the behavior is the same :(

Also, when I use :SpelunkerAddAll it prints this:

screenshot

I hope it will help. Thanks for your work!

@kamykn
Copy link
Owner

kamykn commented Apr 25, 2020

@rasuru

Also, when I use :SpelunkerAddAll it prints this:

I think this error message should have been fixed in pullrequest #38.
If you get this message, spelunker.vim may not be latest version.

@rasuru
Copy link
Author

rasuru commented Apr 25, 2020

I checked the version and also tried to update, but I already do have the latest one 🤷‍♂️

@kamykn
Copy link
Owner

kamykn commented Apr 26, 2020

The behavior is the same when I just add a single word with zg (tried Zg, zw, Zw too).

Vim native commands is zg/zw, but spelunker.vim's commands is Zg/Zw or ZG/ZW.
If you use zg/zw commands, highlighting are not updating. Please use Zg/Zw or ZG/ZW command instead of them.

@rasuru
Copy link
Author

rasuru commented Apr 26, 2020

But I tried all combinations. It just doesn't work.

@kamykn
Copy link
Owner

kamykn commented Apr 26, 2020

Please could you check vim plug setting is updated?

Plug 'kamykn/spelunker.vim', { 'commit': 'd0f892a' } " spell checking

Is already updated this line to Plug 'kamykn/spelunker.vim' " spell checking?

If plugin will not update or already updated, please let me know what is your spelunker.vim's current commit hash ?

@kamykn
Copy link
Owner

kamykn commented Apr 27, 2020

@rasuru
I found another nvim's bug.
If you repeatedly run zg/zw commands for the same word, it will be added them to ~/.config/nvim/spell/en.utf-8.add many times. Spelunker.vim ZG/Zg and ZW/Zw commands also uses zg/zw command too, Spelunker.vim has same problem.

If your ~/.config/nvim/spell/en.utf-8.add is like a below, it doesn't work well.
(This behavior is not reproduced by vim8.)
スクリーンショット 2020-04-27 23 00 32

@rasuru
Copy link
Author

rasuru commented Apr 28, 2020

Yes, I updated the line. Current commit: b37ab6b

There were duplications in this file and I deleted them, but everything works like before. I need to restart the editor, only then the highlighting is gone.

@kamykn
Copy link
Owner

kamykn commented May 1, 2020

@rasuru
I found a small bug about highlights and fixed it.
Please try updating spelunker.vim plugin 🙏 (648f664)

@rasuru
Copy link
Author

rasuru commented May 4, 2020

Hey, everything works as expected! Good job! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants