Fix crash logging

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.34.1] - 2024-08-30
+### Fixed
+- Critical errors were not logged due to logging guard destroyed before the call to tracing
+
 ## [0.34.0] - 2024-08-30
 ### Changed
 - Upgrade kamu-cli version to `0.198.2`

Cargo.toml

@@ -13,8 +13,8 @@ resolver = "2"
 
 [workspace.dependencies]
 # Utils
-graceful-shutdown = { path = "src/utils/graceful-shutdown", version = "0.34.0", default-features = false }
-observability = { path = "src/utils/observability", version = "0.34.0", default-features = false }
+graceful-shutdown = { path = "src/utils/graceful-shutdown", version = "0.34.1", default-features = false }
+observability = { path = "src/utils/observability", version = "0.34.1", default-features = false }
 # Utils (core)
 container-runtime = { git = "https://github.com/kamu-data/kamu-cli", tag = "v0.198.2", version = "0.198.2", default-features = false }
 database-common = { git = "https://github.com/kamu-data/kamu-cli", tag = "v0.198.2", version = "0.198.2", default-features = false }
@@ -60,7 +60,7 @@ kamu-auth-rebac-sqlite = { git = "https://github.com/kamu-data/kamu-cli", tag =
 
 
 [workspace.package]
-version = "0.34.0"
+version = "0.34.1"
 edition = "2021"
 homepage = "https://github.com/kamu-data/kamu-platform"
 repository = "https://github.com/kamu-data/kamu-platform"

LICENSE.txt

@@ -11,7 +11,7 @@ Business Source License 1.1
 
 Licensor:                  Kamu Data, Inc.
 
-Licensed Work:             Kamu Platform Version 0.34.0
+Licensed Work:             Kamu Platform Version 0.34.1
                            The Licensed Work is © 2023 Kamu Data, Inc.
 
 Additional Use Grant:      You may use the Licensed Work for any purpose,

src/app/api-server/src/main.rs

@@ -7,8 +7,6 @@
 // the Business Source License, use of this software will be governed
 // by the Apache License, Version 2.0.
 
-use internal_error::InternalError;
-
 /////////////////////////////////////////////////////////////////////////////////////////
 
 fn main() {
@@ -30,22 +28,24 @@ fn main() {
 
     let rt = builder.enable_all().build().unwrap();
 
-    match rt.block_on(main_async(matches, config)) {
-        Ok(_) => {}
-        Err(err) => {
-            eprintln!("Error: {err}\nDetails: {err:#?}");
-            std::process::exit(1)
-        }
-    }
+    let code = rt.block_on(main_async(matches, config));
+
+    std::process::exit(code)
 }
 
 async fn main_async(
     args: clap::ArgMatches,
     config: kamu_api_server::config::ApiServerConfig,
-) -> Result<(), InternalError> {
+) -> i32 {
     use kamu_api_server::app;
 
     let _guard = app::init_observability();
 
-    kamu_api_server::app::run(args, config).await
+    match kamu_api_server::app::run(args, config).await {
+        Ok(_) => {}
+        Err(err) => {
+            eprintln!("Error: {err}\nDetails: {err:#?}");
+            1
+        }
+    }
 }

src/app/oracle-provider/src/main.rs

@@ -8,7 +8,6 @@
 // by the Apache License, Version 2.0.
 
 use clap::Parser;
-use internal_error::InternalError;
 use kamu_oracle_provider::{Cli, Config};
 
 /////////////////////////////////////////////////////////////////////////////////////////
@@ -27,16 +26,18 @@ fn main() {
         .build()
         .unwrap();
 
-    match rt.block_on(main_async(args, config)) {
-        Ok(_) => {}
+    let code = rt.block_on(main_async(args, config));
+
+    std::process::exit(code)
+}
+
+async fn main_async(args: Cli, config: Config) -> i32 {
+    let _guard = kamu_oracle_provider::app::init_observability();
+    match kamu_oracle_provider::app::run(args, config).await {
+        Ok(_) => 0,
         Err(err) => {
             tracing::error!(error = %err, error_dbg = ?err, "Provider exited with error");
-            std::process::exit(1)
+            1
         }
     }
 }
-
-async fn main_async(args: Cli, config: Config) -> Result<(), InternalError> {
-    let _guard = kamu_oracle_provider::app::init_observability();
-    kamu_oracle_provider::app::run(args, config).await
-}