Introduced DatasetRegistry abstraction, encapsulating listing and resolution of datasets #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaychenko-sergei
force-pushed
the
857-show-tables-query-times-out-after-a-minute
branch
3 times, most recently
from
a5e494f to
e7e895e
Compare
sergiimk
reviewed
Nov 15, 2024
sergiimk
reviewed
Nov 17, 2024
src/domain/task-system/services/src/task_logical_plan_runner_impl.rs
Outdated
Show resolved
Hide resolved
zaychenko-sergei
force-pushed
the
857-show-tables-query-times-out-after-a-minute
branch
5 times, most recently
from
c701dd7 to
112638d
Compare
zaychenko-sergei
changed the title
…esolution of datasets. Key changes: - Registry is backed by database-stored dataset entries, which are automatically maintained - Scope for `DatasetRepository` is now limited to support `DatasetRegistry` and in-memory dataset dependency graph - New concept of `ResolvedDataset`: a wrapper arround `Arc<dyn Dataset>`, aware of dataset identity - `DatasetRegistryRepoBridge` utility connects both abstractions in a simple way for testing needs - Query and Dataset Search functions now consider only the datasets accessible for current user - Core services now explicitly separate planning (transactional) and execution (non-transactional) processing phases - Similar decomposition introduced in task system execution logic - Revised implementation of core commands and services: `pull`, `push`, `reset`, `verify`, `compact`, setting watermark - More parallelism from `pull` command, allowing to mix ingest/sync/transform operations of the same depth level - Optimized `pull` flow, when a single non-recursive dataset is sent for processing - Batched form for dataset authorization checks - Ensuring correct transactionality for dataset lookup and authorization checks all over the code base - Passing multi/single tenancy as an enum configuration instead of boolean - Renamed outbox "durability" term to "delivery mechanism" to clarify the design intent - Greatly reduced complexity and code duplication of many use case and service tests with `oop` macro for inheritance of harnesses
zaychenko-sergei
force-pushed
the
857-show-tables-query-times-out-after-a-minute
branch
from
112638d to
02d8c7c
Compare
zaychenko-sergei
deleted the
857-show-tables-query-times-out-after-a-minute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #857.
Introduced
DatasetRegistryabstraction, encapsulating listing and resolution of datasets.Key changes:
DatasetRepositoryis now limited to supportDatasetRegistryand in-memory dataset dependency graphResolvedDataset: a wrapper arroundArc<dyn Dataset>, aware of dataset identityDatasetRegistryRepoBridgeutility connects both abstractions in a simple way for testing needspull,push,reset,verify,compact, setting watermarkkamu uiandkamu system api-servernow require to be backed by a db transactionpullcommand, allowing to mix ingest/sync/transform operations of the same depth levelpullflow, when a single non-recursive dataset is sent for processingoopmacro for inheritance of harnessesChecklist before requesting a review