Experiment/sqlx #558
Merged
Experiment/sqlx #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiimk
reviewed
Mar 22, 2024
src/database/sqlx-mysql/tests/repositories/test_mysql_account_repository.rs
Outdated
Show resolved
Hide resolved
zaychenko-sergei
force-pushed
the
experiment/sqlx
branch
from
9d1fee6 to
b2960ad
Compare
sergiimk
reviewed
Mar 31, 2024
src/infra/task-system/postgres/src/task_system_event_store_postgres.rs
Outdated
Show resolved
Hide resolved
src/infra/task-system/postgres/src/task_system_event_store_postgres.rs
Outdated
Show resolved
Hide resolved
src/database/database-common/src/transactions/mysql_transaction_manager.rs
Outdated
Show resolved
Hide resolved
src/database/migrations/postgres/20240314140913_accounts_table.sql
Outdated
Show resolved
Hide resolved
src/database/migrations/postgres/20240314140913_accounts_table.sql
Outdated
Show resolved
Hide resolved
Verry dummy sketch of how to connect to Postgres and MariaDB/MySQL databases and write & read an account information Separate crates for common database definitions, PostgreSQL and MySQL specific definitions - to run both databases simultaneously Enable SQLX offline mode for GH Added check of offline data in `make lint` script Very basic look of repositories and db-specific components initializer Simplified initializers of database components Sketched how transactions management might look like Prototyped how testing repositories might look like based on `sqlx:test` macro. Transaction subject hidden in catalog behind double pointer and asynchronous mutex Added automation for local SQLX setup. Extended DEVELOPER.md documentation covering database topics. Experiment with GH actions Marked database tests with testgroups, disabled database tests on all platforms except Linux Review: got rid of `unsafe` Send for transaction Review: TransactionSubject => Transaction Review: separated transaction managers into dedicated components Review: not wrapping connection pools, using directly in dill::Catalog Review: got rid of async-closure Review: explicit transaction rollback on error Improve transaction ergonomics Reorganized domain repository crates. Simplified database crates. Makefile has a list of Postgres and MySQL crates and expands them in typical commands Added top .env file with offline mode enabled by default. `make sqlx-local-setup` uses lists of dependent crates for all steps. Automated `make sqlx-local-clean` action that reverses the effect of `make sqlx-local-setup`. Updated manual with the strategy of having SQLX_OFFLINE mode enabled by default. Reorganized crates of "task-system" domain Draft of Task System's Postgres repository implementation. Pagination support for task events Support real streaming in Postgres task event store Support bulk insert Support windowing Extended and unified test suite for tasks repositories: applying identical checks for in-mem and Postgres implementation
zaychenko-sergei
force-pushed
the
experiment/sqlx
branch
from
d89e017 to
e3effd9
Compare
sergiimk
approved these changes
Apr 8, 2024
sergiimk
reviewed
Apr 8, 2024
sergiimk
reviewed
Apr 8, 2024
sergiimk
reviewed
Apr 8, 2024
src/utils/database-common/src/transactions/db_transaction_manager.rs
Outdated
Show resolved
Hide resolved
sergiimk
reviewed
Apr 8, 2024
src/utils/database-common/src/transactions/db_transaction_manager.rs
Outdated
Show resolved
Hide resolved
sergiimk
reviewed
Apr 8, 2024
src/utils/database-common/src/transactions/db_transaction_manager.rs
Outdated
Show resolved
Hide resolved
sergiimk
reviewed
Apr 8, 2024
sergiimk
reviewed
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prototyped SQLX infrastructure to support persistent domains.
Checklist before requesting a review