Support searching in ODF repos #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiimk
force-pushed
the
feature/search-in-odf-repos
branch
from
cce15e3 to
731fe60
Compare
sergiimk
commented
Feb 27, 2024
| @@ -139,7 +139,7 @@ impl PullServiceImpl { | |||
| Some( | |||
| DatasetRefRemote::Alias(alias) | |||
| | DatasetRefRemote::Handle(DatasetHandleRemote { alias, .. }), | |||
| ) => DatasetAlias::new(alias.account_name.clone(), alias.dataset_name.clone()), | |||
| ) => DatasetAlias::new(None, alias.dataset_name.clone()), | |||
There was a problem hiding this comment.
kamu pull repo/account/dataset was inferring destination alias as account/dataset which was of course confusing the single-tenant repo (panic). In case of a multi-tenant local repo I think it's still correct to default to current user (account=None)
sergiimk
commented
Feb 27, 2024
| let http_url = Url::parse(url.as_str().strip_prefix("odf+").unwrap()).unwrap(); | ||
| let ds = Self::get_http( | ||
| &http_url, | ||
| self.build_header_map(&http_url), |
There was a problem hiding this comment.
Per #521 kamu pull repo/account/dataset was resulting in using SimpleTP with odf+http protocol and the build_header_map here was crashing when accessing .kamutokenstore as it expected raw http/https URL. So I'm stripping off odf+ schema here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #508
odf+http[s]protocolChecklist before requesting a review