Additional handling of Files in TarEntries #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iterating over the tar stream, each Entry will get a reference to the associated File. Added a utility method for easily retrieving all of the TarEntries in a given archive. Updated/added unit tests accordingly.
liyujiang-gzu
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using your library today and there was some functionality that I felt would make the library a bit easier to use. Thanks for your effort in creating this utility, it doesn't seem like there is much else out there except for the bloated Apache library. The commit changes below are pretty self-explanatory. Let me know what you think.
Note that some small tweaks were required for the unit tests because the bytesRead count now must also include the bytes of the file just read.