-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for bool via kabool wrapper #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this proposal. However, there are a few things like to be added:
- Tests for at leas one other MPI operation currently available in KaMPI.ng
- automatic conversion (with runtime overhead) from
std::vector<bool>
tostd::vector::<kabool>
I don't like automatic conversion from std::vector<bool> data = {...};
std::vector<kabool> data_to_send {data.begin(), data.end()}; |
Co-authored-by: Florian Kurpicz <[email protected]>
It might be a topic to be discussed with all developers but I agree that automatic conversion would be nice. |
|
Co-authored-by: Demian Hespe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests for make_data_buffer
and possibly for the buffer factories. I think these are more important than the many tests for some operations that you added. They should just work if the buffer factories work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's annoying, but OwnContainer
has do much non-trivial code that I think it should have tests.
This fixes #219