Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade okhttp3 to 4.x for kamon-prometheus #1183

Closed
t-bast opened this issue Jun 22, 2022 · 1 comment · Fixed by #1226
Closed

Upgrade okhttp3 to 4.x for kamon-prometheus #1183

t-bast opened this issue Jun 22, 2022 · 1 comment · Fixed by #1226

Comments

@t-bast
Copy link

t-bast commented Jun 22, 2022

Kamon currently depends on an old version of okhttp3 (see Build.scala):

val okHttp            = "com.squareup.okhttp3"  %  "okhttp"          % "3.14.7"

This creates issues with other packages such as com.softwaremill.sttp.client3:okhttp-backend who have upgraded to okhttp3 version 4.9.3: adding a dependency to kamon-prometheus effectively downgrades the okhttp package in my class path, which breaks my application.

It would be really nice to upgrade Kamon to the latest version of okhttp3, is this something you could consider?

@eyalfa
Copy link

eyalfa commented Jul 26, 2022

hi, we've encountered this issue due to compliance requirements (see square/okhttp#6724).

we were able to mitigate by simply introducing the latest okhttp version as a direct dependency of our application, tested by accessing the kamon-prometheus endpoint in a browser).

will you guys be willing to accept a (tiny) PR increasing okhttp version?

azolotko pushed a commit to azolotko/Kamon that referenced this issue Nov 3, 2022
ivantopo pushed a commit that referenced this issue Nov 21, 2022
Resolves #1183

Co-authored-by: Alex Zolotko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants