Report span duration in logs

[JR-Utily]

I would like to log the duration time of my Spans after I call span.finish()
How can I report directly in my logger ?
There was this project but I think it is not compatible anymore with new versions https://github.com/kamon-io/kamon-log-reporter

I'm not sure if my current POC doesn't work because of my usage of spans, or because of my implementation of Reporter

I do create some spans with

 val span1 = Kamon.spanBuilder("Test 1").start()
  Kamon.runWithSpan(span1) {
 }
 span1.finish()

and others directly with

Kamon.runWithSpan(Kamon.spanBuilder("Test 2").start(), finishSpan = true) {
}

I tried to implement a CombinedReporter and to declare it in my application.conf, but I don't get any logs from Spans. More precisely, spans: Seq[Span.Finished] is always empty.

class LogReporter extends CombinedReporter with LazyLogging {

  override def reportSpans(spans: Seq[Span.Finished]): Unit = {
    spans.foreach {
      case Span.Finished(id, trace, parentId, operationName, hasError, wasDelayed, from, to, kind,
      position, tags, metricTags, marks, links) =>
        logger.info(s"$id id -> $id")
        logger.info(s"$id trace -> $trace")
        logger.info(s"$id parentId -> $parentId")
        logger.info(s"$id operationName -> $operationName")
        logger.info(s"$id hasError -> $hasError")
        logger.info(s"$id wasDelayed -> $wasDelayed")
        logger.info(s"$id from -> $from")
        logger.info(s"$id to -> $to")
        logger.info(s"$id kind -> $kind")
        logger.info(s"$id position -> $position")
        logger.info(s"$id tags -> $tags")
        logger.info(s"$id metricTags -> $metricTags")
        logger.info(s"$id marks -> $marks")
        logger.info(s"$id links -> $links")
    }
  }

  def reportPeriodSnapshot(snapshot: PeriodSnapshot): Unit = {

    snapshot match {
      case PeriodSnapshot(from, to, counters, gauges, histograms, timers, rangeSamplers) =>
        logger.info(s"from -> $from")
        logger.info(s"to -> $to")
        logger.info(s"counters -> $counters")
        logger.info(s"gauges -> $gauges")
        logger.info(s"histos -> $histograms")
        logger.info(s"timers -> $timers")
        logger.info(s"range -> $rangeSamplers")
    }
  }


  override def stop(): Unit = {
    logger.warn("Nothing to do before stopping")
  }

  override def reconfigure(newConfig: Config): Unit = {
    logger.warn("Didn't take into account any conf !")
  }
}

class LogReporterFactory extends ModuleFactory {
  override def create(settings: ModuleFactory.Settings): LogReporter = new LogReporter()
}

kamon {
  modules {
    log-reporter {
      enabled = true
      name = "Log Reporter"
      description = "Sends reports to current logger"
      factory = "com.company.logging.LogReporterFactory"
    }
  }
  trace.tick-interval = 2 seconds
}

[SimunKaracic]

The code looks fine, this is most likely a sampling issue.
Did you try changing kamon.trace.sampler to always, to make sure that all spans get reported?

Also, are the spans showing up when using a different reporter?

[JR-Utily]

It works with kamon.trace.sampler = always !
I was not aware of this conf. Thanks !

[cdavid]

@JR-Utily - I am trying to build something similar, but in Java + Play Framework. I am hitting a wall when trying to configure the module, it seems that it can not be found (see error below). Did you face similar issues and did you publish the code somewhere?

Thanks in advance!

I am hitting this error at runtime (kanela.yb.KamonLogReporterFactory is my factory):

[warn] k.m.ModuleRegistry - Failed to create instance of module [Log-reporter]
java.lang.ClassNotFoundException: kanela.yb.KamonLogReporterFactory
	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
	at kamon.instrumentation.sbt.KanelaOnSystemClassLoader.loadClass(KanelaOnSystemClassLoader.java:31)
	at kamon.instrumentation.sbt.play.SbtKanelaRunnerPlay$SbtKanelaClassLoader.loadClass(SbtKanelaRunnerPlay.scala:76)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
	at kamon.util.DynamicAccess.getClassFor(DynamicAccess.scala:37)

[JR-Utily]

Sorry, 2 years later, I don't remember.
But if it needed something else, knowing myself, I would have posted here :)

[cdavid]

Makes sense, thanks for the follow-up, greatly appreciated. In my digging, I assume it is related to the usage of the Play framework - were you using the Play framework by any chance or something else? Thanks again!

[JR-Utily]

Yes of course it is with play LazyLogging is just a lazy way (both for the dev and the jvm :) ) to have a logger ready Envoyé avec la messagerie sécurisée [Proton Mail](https://proton.me/).

…

------- Original Message ------- Le lundi 20 juin 2022 à 19:00, cdavid ***@***.***> a écrit :

Makes sense, thanks for the follow-up, greatly appreciated. In my digging, I assume it is related to the usage of the Play framework - were you using the Play framework by any chance or something else? Thanks again! — Reply to this email directly, [view it on GitHub](#878 (reply in thread)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAKPCJNPIWKH7Z4WYXKBB3DVQCPTZANCNFSM4SYMYS2Q). You are receiving this because you were mentioned.Message ID: ***@***.***>