-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and Python 3 support #110
Conversation
So far I'm thinking the host's python2 version might be important. I think we need 2.7.9 and above for the hashlib stuff to work right.
Note: Just because we HAVE python3 support doesn't mean we'll use it by default! No need to run it through 2to3 or anything, same code runs fine on both interpreters. YMMV for pypy! Tested on: Just a note to aid in review, clicking on the 'files' tab at the top will merge all the changesets into one. |
I have installed the latest commit from your repo and tested again to double-confirm. Host system running Python 2.7.6 on Xubuntu 14.04, works with both UMR and Xubuntu 14.04 32-bit ISO images. All looks good, so I will proceed to merge pull request. I have already added your name into listing in this earlier commit. Thanks again for your contributions! |
Cool. Had a test with a 512MB VM, no swap. Got an 800MB ISO out of it. |
My mistake for not checking properly.. Finally replaced `f45d7e4` with correct commit `2a7864f` (when merging pull request #110 from kamilion/master on Sep 4).
As discussed in #109 all updates have been tested.
Some notes on changes I made to how terminals launch:
To resolve the problems I was having with the terminal, I added a last terminal to check for, x-terminal-emulator, which will invoke debian's alternatives system to select the terminal the user has expressed a preference for.
Make sure your /etc/alternatives/x-terminal-emulator is linked to the terminal you'd like customizer to use.
will list known terminals, and
will display a list for you to choose a new one you prefer better.
It's the last terminal in the list; so if it doesn't exist, you'll end up with the last one found.
So, for you people on Arch, it should still work without debian's alternatives system around. \o/
gnome-terminal seems to be having issues after it's split into a backend/frontend process and which method was used as elevation to root -- pkexec, gksudo, or sudo.
pkexec seems to work best on older releases like 14.04, but fails on 15.10 with Xmir :0.0 errors.
gksudo seems to work on 15.04 and 15.10, but xubuntu doesn't have the gksu package.