Xray #447
Xray #447
Conversation
The API isn't used yet, but it's an obvious "add commands to run these" marker
| if (!xr.isEnabled()) { | ||
| Command.sendChatMessage("&cWarning: The XRay module is not enabled."); | ||
| Command.sendChatMessage("&cThese commands will still have effects, but will not visibly do anything."); | ||
| } |
There was a problem hiding this comment.
Reminder for myself to change this to send warning message
| if (xr == null) { | ||
| Command.sendChatMessage("&cThe XRay module is not available for some reason."); | ||
| return; | ||
| } |
| super("xray", new ChunkBuilder().append("subcommand").build()); | ||
| setDescription("Has a set of sub-commands to control the XRay module."); | ||
| } |
There was a problem hiding this comment.
Better description and aliases
|
Also add a xray thing to .help if it doesn't already have a proper help I'm sleepy |
|
Also, if a |
|
The |
|
Oh it already is? |
|
Yes, but since it's an internal detail of the setting the relevant code is in the XRay module itself. |
|
Oooh ok, thank you, that's good to know. |
|
Now this is only waiting for 1 merge conflict and to change the stuff to sendErrorMessage and everything. I'll go eat something first I guess |
|
To be specific:
|
|
A note: The name of the block states/etc. is dependent on mod ID, which might cause trouble for the merge. |
|
Huh, where is that defined? And why is it dependant on it? |
|
The XRay defines a block. Check resources. The Java code will be fine, but the block JSON has |
|
Er, just to be clear, the current state of feature/master will probably malfunction as the |
|
If you see in #289 I just changed the references, but I should be using kamiblue for the folder name as well. Just curious, why did you do those json things instead of using a ResourceLocation? |
|
If ResourceLocations are able to dynamically define blocks without any JSON support files, then it'd be good to switch to that; I wasn't aware of it and went with the "default" method for adding a new block. |
|
Ah. I'm not sure if how exactly this works, I haven't looked to closely at it but basically you can just open a resource location to a file and use it as a texture, look at how InventoryPreview does it. |
|
Using it as a texture, yes, but the XRay doesn't actually do any rendering, as that could cause problems with OptiFine/etc. |
|
oooh ok. makes sense now c: |
This comment has been minimized.
This comment has been minimized.
Closes #289
Unblocks #11, #394 and #429