Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

AutoMend #242

Closed
5HT2 opened this issue Dec 6, 2019 · 6 comments
Closed

AutoMend #242

5HT2 opened this issue Dec 6, 2019 · 6 comments
Assignees
@5HT2
Labels
-module enhancement
Milestone
v1.1.3

Comments

@5HT2
Copy link
Member

5HT2 commented Dec 6, 2019 •
edited
Loading

No description provided.

@5HT2 5HT2 added this to the v1.1.2 milestone Dec 6, 2019
@5HT2 5HT2 mentioned this issue Jan 13, 2020
Closed
20 tasks
@5HT2 5HT2 modified the milestones: v1.1.2, v1.1.3 Jan 14, 2020
@Vonr Vonr self-assigned this Jan 14, 2020
@Vonr
Copy link
Contributor

Vonr commented Jan 14, 2020

done in https://github.com/S-B99/KAMI/commits/feature/autoexp-improvements a long time ago

@pol-y-mer
Copy link
Contributor

I'd love to enhance/implement this if it's not done already :)

@Vonr
Copy link
Contributor

Vonr commented Jan 15, 2020

its broken or something so go test for bella and report to her in discord thanksss

@5HT2
Copy link
Member Author

5HT2 commented Jan 15, 2020

this is aaaa supposed to be done

@5HT2
Copy link
Member Author

5HT2 commented Jan 15, 2020

all you need to do is checkout the branch and test

@5HT2
Copy link
Member Author

5HT2 commented Jan 15, 2020

@Vonr it works, but if you lose a piece of armour it breaks, says it crashes at the divide, because there is no stack.getitemdamage, because there is no item. It ignores the itemstack empty check, meaning the method that runs it needs to check if it's not empty

5HT2 added a commit that referenced this issue Jan 15, 2020
@5HT2
add untested checks for #242
ac49254
5HT2 added a commit that referenced this issue Jan 15, 2020
@5HT2
untested fix the things for #242
2937124
@5HT2 5HT2 modified the milestones: v1.1.2, v1.1.3 Jan 19, 2020
@5HT2 5HT2 assigned 5HT2 and unassigned Vonr Feb 26, 2020
@5HT2 5HT2 changed the title AutoExp durability check AutoMend Mar 25, 2020
@5HT2 5HT2 mentioned this issue Apr 6, 2020
Closed
4 tasks
@5HT2 5HT2 closed this as completed in 9fff155 Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@5HT2 5HT2

Labels
-module enhancement
Projects
None yet
Milestone
v1.1.3
Development

No branches or pull requests
3 participants
@5HT2 @Vonr @pol-y-mer