Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo "Falvors" in conversionProfile template #9536

Open
wants to merge 1 commit into
base: Propus-16.5.0
Choose a base branch
from
Open

Typo "Falvors" in conversionProfile template #9536

wants to merge 1 commit into from

Conversation

bluikko
Copy link

@bluikko bluikko commented Jun 29, 2020

Flavors typed wrong as "Falvors"

Flavors typed wrong as "Falvors"
@bluikko
Copy link
Author

bluikko commented Jun 29, 2020

There is a bunch of similar typos in file flavorParamsAction.class.php... those are not visible in the UI but should probably be fixed as well. The file KDLWrap.php also has one mention of "KDLFalvor".

@bluikko
Copy link
Author

bluikko commented Jun 29, 2020

I see that this PR cannot be merged as-is, there are other files that refer to "INGESTED_FALVORS":

  • commands.cfg.template
  • cluster_commands.cfg.template

And finally file myEntryUtils.class.php has two more occurrences of "falvor".

Is this really a typo? Seems to me but I'm just a server administrator and do not wish to get too involved with how Kaltura works. If someone can confirm it indeed should be "flavor" I could then submit a complete PR if needed - but there could be impact on already installed systems that are updated to new version if only the templates are fixed from "falvor" to "flavor"?

If it is really an error I guess it cannot be called a typo, looks like someone used "falvor" everywhere, incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant