Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12189): Stream doesn't start if open a program with a bookmark #652

Merged
merged 11 commits into from
Oct 2, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Jun 12, 2022

Description of the Changes

Solves FEC-12189

pr:
kaltura/playkit-js-dash#194

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

JonathanTGold added a commit to kaltura/playkit-js-dash that referenced this pull request Jun 26, 2022
src/player-config.js Show resolved Hide resolved
SivanA-Kaltura
SivanA-Kaltura previously approved these changes Oct 2, 2022
docs/configuration.md Outdated Show resolved Hide resolved
Co-authored-by: Sivan Agranov <[email protected]>
@JonathanTGold JonathanTGold merged commit 2da12c9 into master Oct 2, 2022
JonathanTGold added a commit to kaltura/playkit-js-dash that referenced this pull request Oct 2, 2022
#211)

related pr: kaltura/playkit-js#652

Following the removal of the LowLatencyMode from the default configuration here, we need to check if the field exists, otherwise, it will return undefined
borhandarabi pushed a commit to TasvirChi/playchi-js-dash that referenced this pull request May 14, 2024
borhandarabi pushed a commit to TasvirChi/playchi-js-dash that referenced this pull request May 14, 2024
…k (#211)

related pr: kaltura/playkit-js#652

Following the removal of the LowLatencyMode from the default configuration here, we need to check if the field exists, otherwise, it will return undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants