fix(FEC-12848): set abr.capLevelOnFPSDrop to default false. (#696)

"capLevelOnFPSDrop": false
kaltura · Jan 18, 2023 · f22b4c7 · f22b4c7
1 parent 181d4af
commit f22b4c7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/docs/configuration.md b/docs/configuration.md
@@ -85,7 +85,7 @@ var config = {
     enabled: true,
     fpsDroppedFramesInterval: 5000,
     fpsDroppedMonitoringThreshold: 0.2,
-    capLevelOnFPSDrop: true,
+    capLevelOnFPSDrop: false,
     capLevelToPlayerSize: false,
     restrictions: {
       minHeight: 0,
@@ -1584,7 +1584,7 @@ var config = {
 >   enabled: true,
 >   fpsDroppedFramesInterval: 5000,
 >   fpsDroppedMonitoringThreshold: 0.2,
->   capLevelOnFPSDrop: true,
+>   capLevelOnFPSDrop: false,
 >   capLevelToPlayerSize: false,
 >   restrictions: {
 >     minHeight: 0,
@@ -1633,7 +1633,7 @@ var config = {
 > >
 > > ##### Type: `boolean`
 > >
-> > ##### Default: true
+> > ##### Default: false
 > >
 > > ##### Description: If the player should cap the level when the fps exceeds the threshold.
 > >

diff --git a/src/engines/dropped-frames-watcher.js b/src/engines/dropped-frames-watcher.js
@@ -32,7 +32,10 @@ class DroppedFramesWatcher extends FakeEventTarget {
     if (this._getDroppedAndDecodedFrames()[0] === NOT_SUPPORTED) {
       DroppedFramesWatcher._logger.debug('Dropped frame watcher is not supported');
     } else if (this._config.capLevelOnFPSDrop) {
+      DroppedFramesWatcher._logger.debug('Initialized capLevelOnFPSDrop = true');
       this._init();
+    } else {
+      DroppedFramesWatcher._logger.debug('Not Initialized');
     }
   }
 

diff --git a/src/player-config.js b/src/player-config.js
@@ -65,7 +65,7 @@ const DefaultConfig = {
     enabled: true,
     fpsDroppedFramesInterval: 5000,
     fpsDroppedMonitoringThreshold: 0.2,
-    capLevelOnFPSDrop: true,
+    capLevelOnFPSDrop: false,
     capLevelToPlayerSize: false,
     restrictions: {
       minHeight: 0,