Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12132): Add documentation #8

Merged
merged 14 commits into from
Jul 18, 2022
Merged

fix(FEC-12132): Add documentation #8

merged 14 commits into from
Jul 18, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Jun 14, 2022

Description of the Changes

Add documentation and update types

solves: FEC-12132

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

docs/guide.md Outdated Show resolved Hide resolved
docs/guide.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/guide.md Show resolved Hide resolved
@JonathanTGold JonathanTGold merged commit b3b9e3e into master Jul 18, 2022
Tzipi-kaltura added a commit that referenced this pull request Nov 7, 2024
…r issues Priority 2(#8) transcript panel does not immediately follow the toggle button
Tzipi-kaltura added a commit that referenced this pull request Nov 7, 2024
…r issues Priority 2(#8) transcript panel does not immediately follow the toggle button (#66)

Add functionality to focus on plugin button and in case it's inside more button it focus will be on more plugin
Tzipi-kaltura added a commit that referenced this pull request Nov 19, 2024
…r issues Priority 2(#8) transcript panel does not immediately follow the toggle button
Tzipi-kaltura added a commit that referenced this pull request Nov 20, 2024
#68)

…r issues Priority 2(#8) transcript panel does not immediately follow the toggle button

Description of the Changes
Adding event.preventDefault before we focus the button.

part of kaltura/playkit-js-transcript#228

solves ADA-1777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants