Fev 374 - improve preloaded #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
semarche-kaltura
commented
Oct 8, 2019
semarche-kaltura
commented
- set correct icon and animation for loading indicator
- small style changes for an error icon
eitanavgil
changed the title
eitanavgil
suggested changes
Oct 17, 2019
There was a problem hiding this comment.
@semarche-kaltura
I don't see anything risk in this ticket - but it seems irrelevant to the ticket description.
Is that an error?
eitanavgil
changed the title
eitanavgil
approved these changes
Oct 17, 2019
Tzipi-kaltura
added a commit
that referenced
this pull request
Nov 5, 2024
…r issues Priority 2(#8) transcript panel does not immediately follow the toggle button
Tzipi-kaltura
added a commit
that referenced
this pull request
Nov 7, 2024
…r issues Priority 2(#8) transcript panel does not immediately follow the toggle button (#222) Issue: When user press shift+tab inside transcript plugin after first element - search input, focus move to last element in bottom bar and not to transcript button. Fix: Add listener to search input so we user focus on it and press shift tab focus will move to transcript button or to more button (if transcript inside more dropdown) Solves ADA-1777
Tzipi-kaltura
added a commit
that referenced
this pull request
Nov 19, 2024
…r issues Priority 2(#8) transcript panel does not immediately follow the toggle button
Tzipi-kaltura
added a commit
that referenced
this pull request
Nov 19, 2024
…r issues Priority 2(#8) transcript panel does not immediately follow the toggle button
Tzipi-kaltura
added a commit
that referenced
this pull request
Nov 20, 2024
…r issues Priority 2(#8) transcript panel does not immediately follow the toggle button (#228) Sending the event to focusPluginButton function then only in case we have transcript/more button on the dom - we will use event.preventDefault() functionality. so if these elements are not exist on the dom, tab will be moved the previous element as usually. (in case player is too small and top bar buttons are removed) Add the listener to first_play only if this is indeed the first play (before video is played - when preload is enabled) and if the component is called after the first play - listener to keydown is added immediately part of - kaltura/playkit-js-ui-managers#68 solves ADA-1777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.