Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-9247): add userId to kava reports #45

Merged
merged 6 commits into from
Jul 25, 2019
Merged

fix(FEC-9247): add userId to kava reports #45

merged 6 commits into from
Jul 25, 2019

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Jul 22, 2019

Description of the Changes

add userId from kava config

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke Yuvalke requested a review from OrenMe July 22, 2019 11:41
@Yuvalke Yuvalke self-assigned this Jul 22, 2019
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add test and update docs

src/kava-model.js Outdated Show resolved Hide resolved
src/kava-event-model.js Outdated Show resolved Hide resolved
src/kava-event-model.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
flow-typed/types/kava-config.js Outdated Show resolved Hide resolved
src/kava-model.js Outdated Show resolved Hide resolved
@OrenMe OrenMe changed the title fix(FEC-9247): Add userId to kava reports fix(FEC-9247): add userId to kava reports Jul 22, 2019
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update docs, see

* @typedef {Object} KavaConfigObject
* @property {string} [serviceUrl] - The Kaltura API server.
* @property {number} [viewEventCountdown] - The interval in seconds that VIEW event will be sent.
* @property {number} [resetSessionCountdown] - The interval in seconds that Kava session will be reset.
* @property {number} [dvrThreshold] - Threshold in seconds from the live edge.
* @property {string} [applicationVersion] - Used to send the application version from which the user is playing the entry.
* @property {string} [playbackContext] - Used to send the id of the category from which the user is playing the entry.
* @property {Function} [tamperAnalyticsHandler] - An optional handler to implement. Can be used to manipulate the model data before analytics event sent, or to cancel a certain analytics request.
* @property {Object} [customVar1] - Custom objects field.
* @property {Object} [customVar2] - Custom objects field.
* @property {Object} [customVar3] - Custom objects field.

@Yuvalke Yuvalke merged commit cda7469 into master Jul 25, 2019
@Yuvalke Yuvalke deleted the FEC-9247 branch July 25, 2019 07:21
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
### Description of the Changes

Download plugin, ignore system attachments

#### Resolves FEC-1373

---------

Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants