Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8452): playlist #25

Merged
merged 3 commits into from
Oct 25, 2018
Merged

feat(FEC-8452): playlist #25

merged 3 commits into from
Oct 25, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Oct 11, 2018 •
edited
Loading

Description of the Changes

report playlistId when existing

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from dan-ziv October 11, 2018 11:58
@yairans yairans merged commit d0363fe into master Oct 25, 2018
@yairans yairans deleted the FEC-8452 branch October 25, 2018 14:39
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@lianbenjamin
feat: add fallback to image download (#25)
0610f69 
### Description of the Changes

in case of an image player, there is a possibility that the HEAD request with `raw` service will fail.
the solution is to add a fallback option by trying to get the image from the image source, that is using the thumbnail service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yairans