Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8320): SOURCE_SELECTED event triggered on user selection of ABR mode #16

Merged
merged 1 commit into from
Jun 14, 2018
Merged

fix(FEC-8320): SOURCE_SELECTED event triggered on user selection of ABR mode #16

merged 1 commit into from
Jun 14, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jun 14, 2018 •
edited
Loading

Description of the Changes

Remove logic of setting actualBitrate of 0 and trigger SOURCE_SELECTED event when user selected ABR mode.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv changed the title remote abr mode changed listener fix: SOURCE_SELECTED event triggered on user selection of ABR mode Jun 14, 2018
@dan-ziv dan-ziv requested a review from OrenMe June 14, 2018 12:59
@dan-ziv dan-ziv self-assigned this Jun 14, 2018
@dan-ziv dan-ziv changed the title fix: SOURCE_SELECTED event triggered on user selection of ABR mode fix(FEC-8320): SOURCE_SELECTED event triggered on user selection of ABR mode Jun 14, 2018
@dan-ziv dan-ziv merged commit 3ca02c8 into master Jun 14, 2018
@dan-ziv dan-ziv deleted the remove-abr-mode-changed-listener branch June 14, 2018 14:14
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@semarche-kaltura
Merge pull request #16 from kaltura/FEC-13265-upd-kaltura-dependency-…
9d1f590 
…script

fix(FEC-13265): upd dependency script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe