Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11492): dash adapter is not destroyed when network is offline #167

Merged
merged 1 commit into from
Aug 18, 2021
Merged

fix(FEC-11492): dash adapter is not destroyed when network is offline #167

merged 1 commit into from
Aug 18, 2021

Conversation

lianbenjamin
Copy link
Collaborator

Description of the Changes

issue:
once dash is triggering critical error event, we are not destroying the engine.

solution:
destroying engine when critical event is being fired.

Solves FEC-11492

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@lianbenjamin lianbenjamin requested a review from yairans August 15, 2021 14:24
@lianbenjamin lianbenjamin merged commit 1c496b5 into master Aug 18, 2021
@lianbenjamin lianbenjamin deleted the FEC-11492 branch August 18, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lianbenjamin @yairans