fix(FEC-11473): start of dvr window is going back and forth while start over #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
previously approved these changes
Aug 9, 2021
OrenMe
reviewed
Aug 11, 2021
src/dash-adapter.js
Outdated
| return this._shaka.seekRange().start + this._shaka.getConfiguration().streaming.safeSeekOffset; | ||
| if (!this._isStartOver) { | ||
| if (this._seekRangeStart > this._shaka.seekRange().start) { | ||
| // seekRange().start seeked back means this is start over |
There was a problem hiding this comment.
so this will only happen for segment list manifests, correct? and also only if api is called in times where condition this._seekRangeStart > this._shaka.seekRange().start is true which doesn't happen all the time.
I think if this is the case we can still leave the calculation in manifest request where this condition will always be correct for segment list manifest
There was a problem hiding this comment.
on manifest request this._shaka.seekRange().start is not updated yet so the condition is still false
OrenMe
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
shaka is increasing the
seekRange.startbetween manifest loadings.so ignore this update if it's start over.
Solves FEC-11473
CheckLists