Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-11082): remove handling of DOM play error on SmartTV on when stall happen on the beginning #137

Merged
merged 2 commits into from
Mar 15, 2021
Merged

fix(FEC-11082): remove handling of DOM play error on SmartTV on when stall happen on the beginning #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba2e89a
fix(FEC-10590): remove the logic from dash adapter
Yuvalke Mar 14, 2021
a178252
Merge branch 'master' into FEC-10590-1
Yuvalke Mar 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/dash-adapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,29 +361,12 @@ export default class DashAdapter extends BaseMediaSourceAdapter {
if (this._config.shakaConfig.useShakaTextTrackDisplay) {
this._shaka.setVideoContainer(Utils.Dom.getElementBySelector('.playkit-subtitles'));
}
this._maybeFixStallForSmartTV();
this._maybeSetFilters();
this._maybeSetDrmConfig();
this._shaka.configure(this._config.shakaConfig);
this._addBindings();
}

/**
* fix stall play promise rejected by seeking on the beginning instead of play pause
* @returns {void}
* @private
*/
_maybeFixStallForSmartTV(): void {
const defaultStallSkip = 0.1;
const currentStallSkip = this._shaka.getConfiguration().streaming.stallSkip;
Utils.Object.mergeDeep(this._config.shakaConfig, {streaming: {stallSkip: defaultStallSkip}});
this._eventManager.listenOnce(this._videoElement, EventType.PLAYING, () => {
if (currentStallSkip !== this._shaka.getConfiguration().streaming.stallSkip) {
this._shaka.configure({streaming: {stallSkip: currentStallSkip}});
}
});
}

/**
* get the redirected URL
* @param {string} url - The url to check for redirection
Expand Down