Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-11082): remove handling of DOM play error on SmartTV on when stall happen on the beginning #137

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Mar 14, 2021

Description of the Changes

Issue: stall detector doesn't get the change of stallSkip after it loaded and stallSkip 0.1 cause freezes on old SmartTV.
Solution: Handle it on playkit kaltura/playkit-js#552

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke Yuvalke requested a review from a team March 14, 2021 10:58
@Yuvalke Yuvalke self-assigned this Mar 14, 2021
@Yuvalke Yuvalke changed the title fix(FEC-10590): remove handling of DOM play error on SmartTV on when stall happen on the beginning fix(FEC-11082): remove handling of DOM play error on SmartTV on when stall happen on the beginning Mar 14, 2021
@Yuvalke Yuvalke merged commit 571ae30 into master Mar 15, 2021
@Yuvalke Yuvalke deleted the FEC-10590-1 branch March 15, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants