Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11112): if cast after the playback started, Play button appears instead of Pause and the scrubber doesn't progress #22

Merged
merged 2 commits into from
Jun 7, 2021
Merged

fix(FEC-11112): if cast after the playback started, Play button appears instead of Pause and the scrubber doesn't progress #22

merged 2 commits into from
Jun 7, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jun 6, 2021

Description of the Changes

Save paused state and call play if we were playing before cast.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from yairans June 6, 2021 06:06
@dan-ziv dan-ziv self-assigned this Jun 6, 2021
@dan-ziv dan-ziv merged commit bc69c50 into master Jun 7, 2021
@dan-ziv dan-ziv deleted the FEC-11112 branch June 7, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @yairans