Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10291): migrate analytics plugins injection from kaltura player to server #337

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 15, 2020

Description of the Changes

remove analytics plugins injection

Related to:
kaltura/server#9592
kaltura/playkit-js-kava#75
kaltura/playkit-js-ott-analytics#35

Solves FEC-10291

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Copy link
Contributor

@dan-ziv dan-ziv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yairans need to remove kava and ott-analytics also from the dependencies in package.json and update yarn.lock

@yairans yairans merged commit 1caf168 into master Jul 16, 2020
@yairans yairans deleted the FEC-10291 branch July 16, 2020 11:35
yairans added a commit to kaltura/playkit-js-kava that referenced this pull request Jul 16, 2020
…yer to server (#75)

Add kava plugin to the deployment flow

Solves FEC-10291

Related to kaltura/kaltura-player-js#337
yairans added a commit to kaltura/playkit-js-ott-analytics that referenced this pull request Jul 16, 2020
…yer to server (#35)

Add ott-analytics plugin to the deployment flow

Solves FEC-10291

Related to kaltura/kaltura-player-js#337
yairans added a commit to kaltura/server that referenced this pull request Aug 3, 2020
… from Kaltura Player to Server (#9592)

Add playkit-kava and playkit-ott-analytics to kaltura-player >= 0.56.0 which doesn't exist these plugins anymore.

Related to kaltura/kaltura-player-js#337
yairans added a commit to kaltura/server that referenced this pull request Aug 3, 2020
… from Kaltura Player to Server (#9592)

Add playkit-kava and playkit-ott-analytics to kaltura-player >= 0.56.0 which doesn't exist these plugins anymore.

Related to kaltura/kaltura-player-js#337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants