Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8228): Incorrect referrer param on the playManifest request a… #124

Merged
merged 1 commit into from
Jun 11, 2018
Merged

fix(FEC-8228): Incorrect referrer param on the playManifest request a… #124

merged 1 commit into from
Jun 11, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 21, 2018 •
edited
Loading

…nd in kanalytics events

Description of the Changes

pass the referrer to kava plugin via config see kaltura/playkit-js-kava#2

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from dan-ziv May 21, 2018 18:47
@yairans yairans mentioned this pull request May 21, 2018
Merged
dan-ziv pushed a commit to kaltura/playkit-js-kava that referenced this pull request May 27, 2018
@yairans
fix(FEC-8228): get referrer as config option (#2)
25f769d 
take the referrer from the config. depends on kaltura/kaltura-player-js#124
@OrenMe
Copy link
Contributor

OrenMe commented Jun 9, 2018

@yairans @dan-ziv merge to kava branch

@dan-ziv dan-ziv merged commit 9e3a49a into kava Jun 11, 2018
@dan-ziv dan-ziv deleted the add-referrer branch June 11, 2018 09:43
dan-ziv pushed a commit that referenced this pull request Jun 11, 2018
feat: kava plugin integration (#90)
de71162 
* Add kava plugin to kaltura player framework.
* Set kAnalony flag to true by default in kanalytics.
* fix(FEC-8228): Incorrect referrer param on the playManifest request and in kanalytics events (#124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@OrenMe OrenMe OrenMe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yairans @OrenMe @dan-ziv