-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added norwegian and hreflang #411
base: master
Are you sure you want to change the base?
Conversation
@tobmcv why did you close that MR? I'm pretty interessed by your additions |
I was trying to make it work on my copy of the repo first and mistakenly submitted it too early. I've managed to make it work now so I'll resubmit my suggestions. |
Removed the language selector since this doesn't look good for the end user. Left the hreflang tag generator in place. This generates link tags to pages in the translated languages so that Google can serve the most relevant translated page in search results to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the branch now. It only adds 2 things now
- A yaml file for Norwegian bokmål, one of the 2 written official versions of Norwegian.
- A function that generates hreflang tags for translated pages on a multilingual blog. These tags are respected by Google and will show the most relevant translated page in search results for people.
Hreflang tags use ISO-codes and can be used to specify languages as well as combinations of languages and country targeting.
Read more about hreflang and the ISO-codes here https://support.google.com/webmasters/answer/189077?hl=en
@kakawait can you review the PR now? It's as complete as I can make it right now. |
@tobiasmcvey I'll do on next day. Thank you for contribution |
@tobiasmcvey sorry for delay (see https://github.com/kakawait/hugo-tranquilpeak-theme/blob/master/CHANGELOG.md#forwords for more details). Since you've created there were new keys, do you think you can translate it? I'm totally zero on Norwegian :) See diff: https://www.diffchecker.com/UtlKyBsw
|
Added
Language selection bar