test(proto): add storage node descriptor validation tests #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
+ Coverage 79.08% 79.99% +0.91%
==========================================
Files 180 179 -1
Lines 21615 21587 -28
==========================================
+ Hits 17094 17269 +175
+ Misses 3711 3531 -180
+ Partials 810 787 -23 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
test_proto_add_unit_tests_for_logstreamreplica
branch
from
ed796f3 to
f953940
Compare
ijsong
force-pushed
the
test_proto_add_storage_node_descriptor_validation_tests
branch
from
acf7b7c to
70db730
Compare
ijsong
force-pushed
the
test_proto_add_unit_tests_for_logstreamreplica
branch
from
f953940 to
6e0ea77
Compare
ijsong
force-pushed
the
test_proto_add_storage_node_descriptor_validation_tests
branch
from
70db730 to
5d84f35
Compare
ijsong
force-pushed
the
test_proto_add_unit_tests_for_logstreamreplica
branch
from
6e0ea77 to
bcae3fc
Compare
ijsong
force-pushed
the
test_proto_add_storage_node_descriptor_validation_tests
branch
from
5d84f35 to
4e83134
Compare
hungryjang
approved these changes
Feb 1, 2025
ijsong
force-pushed
the
test_proto_add_unit_tests_for_logstreamreplica
branch
from
bcae3fc to
8292f4a
Compare
ijsong
force-pushed
the
test_proto_add_storage_node_descriptor_validation_tests
branch
from
4e83134 to
80a2de6
Compare
- Add tests for StorageNodeMetadataDescriptor and LogStreamReplicaMetadataDescriptor - Test methods: ToStorageNodeDescriptor, GetLogStream, Head, and Tail - Ensure proper coverage for edge cases and nil values
- Add comments for SyncPosition.InvalidSyncPosition, SyncPosition.Invalid, SyncPosition.LessThan, SyncRange.InvalidSyncRange, and SyncRange.Validate methods. - Add unit tests for SyncRange validation and invalid cases.
- replaced InvalidLogEntry with an empty LogEntry across the codebase - removed proto/varlogpb/log_entry.go as it contained unused code - updated related files to reflect these changes
- Removed unused functions from metadata.go - Added comprehensive unit tests for metadata.go and metadata_test.go - Improved test coverage for various scenarios
- Added `proto/varlogpb/replica_test.go` to test `EqualReplicas` and `ValidReplicas` functions. - Included various test cases to ensure correct functionality.
- Added new file: proto/varlogpb/storage_node_test.go - Includes tests for StorageNodeDescriptor validation
ijsong
force-pushed
the
test_proto_add_unit_tests_for_logstreamreplica
branch
from
8292f4a to
12997f3
Compare
ijsong
force-pushed
the
test_proto_add_storage_node_descriptor_validation_tests
branch
from
80a2de6 to
ed22dca
Compare
Base automatically changed from
test_proto_add_unit_tests_for_logstreamreplica
to
main
February 3, 2025 12:06
ijsong
deleted the
test_proto_add_storage_node_descriptor_validation_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does