CalcIntType -> long, because int might lead to loss of data… #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams-tschoening
changed the title
… lietral is provided. which should be a regular use case. Long.valueOf(...) shoudl have been optimized in that case for low indices as well, but this way we don't need to care and don't add extra source to the result.
…ts is created: new ArrayList<Long>(Arrays.asList(0, 1, 100500)) doIntLiteral doesn't know that a Long is required and the va.lues itself don't require one,. so doIntLiteral keeps providing the numeric literals without "L" suffix, which results in "int"s by default in Java and an array of int can't be casted to a required array of long.
…Request?prid=494963
…ch lead to compiler errors.
ams-tschoening
force-pushed
the
calcinttype_int_to_long
branch
from
ddf9ced to
e0f79f3
Compare
|
Actually, I wanted to return to this topic. I'll try to check if we can make that transition with the tests and hopefully we'll do it. Current "default is 32-bit int" indeed makes things much more complicated than it could be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in some calculations.
https://github.com/kaitai-io/kaitai_struct_compiler/issues/62