Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: APIs override deprecated parameters #92

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

blukat29
Copy link
Contributor

@blukat29 blukat29 commented Sep 13, 2024

Proposed changes

kaia_getParams, governance_getParams, kaia_getChainConfig, governance_getChainConfig APIs to override deprecated parameters depending on hardfork level. Namely,

Though these fields could be deleted later as in #91, we first return the close-to-reality values to avoid confusion.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

Example

  • kaia_getParams, governance_getParams
     > kaia.getParams(0)
     {
       // ...
       reward.proposerupdateinterval: 3600,
       reward.ratio: "34/54/12",
       reward.stakingupdateinterval: 86400,
       reward.useginicoeff: true
     }
     > kaia.getParams("latest")
     {
       // ...
       reward.proposerupdateinterval: 1,
       reward.ratio: "50/25/25",
       reward.stakingupdateinterval: 1,
       reward.useginicoeff: false
     }
  • kaia_getChainConfig, governance_getChainConfig
     > kaia.getChainConfig(0)
     {
       // ...
          reward: {
           deferredTxFee: true,
           kip82ratio: "20/80",
           minimumStake: 5000000,
           mintingAmount: 9600000000000000000,
           proposerUpdateInterval: 3600,
           ratio: "34/54/12",
           stakingUpdateInterval: 86400,
           useGiniCoeff: true
         }
       // ...
     }
     > kaia.getChainConfig("latest")
     {
       // ...
         reward: {
           deferredTxFee: true,
           kip82ratio: "20/80",
           minimumStake: 5000000,
           mintingAmount: 9600000000000000000,
           proposerUpdateInterval: 1,
           ratio: "50/25/25",
           stakingUpdateInterval: 1,
           useGiniCoeff: false
         }
       },
       // ...
     }

@blukat29 blukat29 merged commit 9537d89 into kaiachain:dev Sep 19, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
@blukat29 blukat29 deleted the override-deprecated-gov-params branch September 24, 2024 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants