governance: APIs override deprecated parameters #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
kaia_getParams
,governance_getParams
,kaia_getChainConfig
,governance_getChainConfig
APIs to override deprecated parameters depending on hardfork level. Namely,reward.useginicoeff
isfalse
as All committee members have an equal chance of being elected block proposers Remove weight and gini coefficient during proposer selection klaytn/klaytn#1655reward.proposerupdateinterval
is1
as proposer list is no longer used, rather proposers are selected every block at random. (kip-146: Random proposer selection based on RANDAO klaytn/klaytn#2030)reward.stakingupdateinterval
is1
as staking information is updated every block, effectively deprecating the interval. (Update validator refresh interval klaytn/klaytn#2154)Though these fields could be deleted later as in #91, we first return the close-to-reality values to avoid confusion.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
Example
kaia_getParams
,governance_getParams
kaia_getChainConfig
,governance_getChainConfig