-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Enable 7702 tests using execution-spec-tests
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulbqb
requested review from
aidan-kwon,
blukat29,
yoomee1313 and
ian0371
as code owners
November 28, 2024 04:16
ian0371
approved these changes
Nov 28, 2024
Mdaiki0730
reviewed
Nov 28, 2024
I'm going to merge this after #154 because of a lot of duplicated contents. |
ulbqb
changed the title
Enable 7702 tests using
Enable 7702 tests using Nov 29, 2024
executiion-spec-tests
execution-spec-tests
ulbqb
changed the title
Enable 7702 tests using
test: Enable 7702 tests using Dec 2, 2024
execution-spec-tests
execution-spec-tests
ulbqb
force-pushed
the
feat/eip-7702-test
branch
2 times, most recently
from
December 4, 2024 04:32
eb1039c
to
536532b
Compare
I force-pushed this because dev branch was merged. |
Did you have conflicts? If so, how did you resolve them? |
blukat29
reviewed
Dec 4, 2024
ulbqb
force-pushed
the
feat/eip-7702-test
branch
from
December 6, 2024 09:01
536532b
to
fe7dc37
Compare
I force-pushed this again because dev branch was merged. |
blukat29
reviewed
Dec 6, 2024
Mdaiki0730
reviewed
Dec 6, 2024
hyeonLewis
reviewed
Dec 9, 2024
blukat29
approved these changes
Dec 9, 2024
Mdaiki0730
approved these changes
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR enables 7702 tests using
execution-spec-test
and fixes some bugs. Some tests skip because of some reasons.main commit: 536532b
skip tests:
bug fix:
obj.created = true
related: #152
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...