Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable 7702 tests using execution-spec-tests #149

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

ulbqb
Copy link
Contributor

@ulbqb ulbqb commented Nov 27, 2024

Proposed changes

This PR enables 7702 tests using execution-spec-test and fixes some bugs. Some tests skip because of some reasons.

main commit: 536532b

skip tests:

  • These files can't be loaded because of json format error
    • prague/eip7702_set_code_tx/set_code_txs/invalid_tx_invalid_auth_signature.json
    • prague/eip7702_set_code_tx/set_code_txs/tx_validity_chain_id.json
    • prague/eip7702_set_code_tx/set_code_txs/tx_validity_nonce.json

bug fix:

  • fix the condition when setting obj.created = true
  • fix to increment nonce for each SetCode tx

related: #152

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@ulbqb ulbqb self-assigned this Nov 27, 2024
@ulbqb ulbqb marked this pull request as ready for review November 28, 2024 04:16
@ulbqb ulbqb requested a review from Mdaiki0730 November 28, 2024 04:16
@ulbqb ulbqb assigned tnasu, shiki-tak and da1suk8 and unassigned tnasu, shiki-tak and da1suk8 Nov 28, 2024
@ulbqb ulbqb requested review from tnasu, shiki-tak and da1suk8 November 28, 2024 04:17
tests/state_test.go Outdated Show resolved Hide resolved
@ulbqb
Copy link
Contributor Author

ulbqb commented Nov 28, 2024

I'm going to merge this after #154 because of a lot of duplicated contents.

@ulbqb ulbqb changed the title Enable 7702 tests using executiion-spec-tests Enable 7702 tests using execution-spec-tests Nov 29, 2024
@ulbqb ulbqb marked this pull request as draft December 2, 2024 07:11
@ulbqb ulbqb changed the title Enable 7702 tests using execution-spec-tests test: Enable 7702 tests using execution-spec-tests Dec 2, 2024
@ulbqb ulbqb force-pushed the feat/eip-7702-test branch 2 times, most recently from eb1039c to 536532b Compare December 4, 2024 04:32
@ulbqb
Copy link
Contributor Author

ulbqb commented Dec 4, 2024

I force-pushed this because dev branch was merged.

@ulbqb ulbqb marked this pull request as ready for review December 4, 2024 04:40
@ulbqb ulbqb requested review from Mdaiki0730 and ian0371 December 4, 2024 04:40
@Mdaiki0730
Copy link
Contributor

Did you have conflicts? If so, how did you resolve them?

@ulbqb ulbqb marked this pull request as draft December 4, 2024 06:34
blockchain/state/statedb.go Outdated Show resolved Hide resolved
blockchain/state/statedb.go Outdated Show resolved Hide resolved
@ulbqb ulbqb force-pushed the feat/eip-7702-test branch from 536532b to fe7dc37 Compare December 6, 2024 09:01
@ulbqb
Copy link
Contributor Author

ulbqb commented Dec 6, 2024

I force-pushed this again because dev branch was merged.

@ulbqb ulbqb requested a review from blukat29 December 6, 2024 09:16
@ulbqb ulbqb marked this pull request as ready for review December 6, 2024 09:20
tests/state_test_util.go Outdated Show resolved Hide resolved
@ulbqb ulbqb requested review from Mdaiki0730 and blukat29 December 9, 2024 04:02
@ulbqb ulbqb merged commit e99c409 into kaiachain:feat/eip-7702 Dec 9, 2024
9 checks passed
@ulbqb ulbqb deleted the feat/eip-7702-test branch December 9, 2024 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants