Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cicd #10

Merged
merged 9 commits into from
Jun 20, 2024
Merged

update cicd #10

merged 9 commits into from
Jun 20, 2024

Conversation

Sotatek-TinnNguyen
Copy link
Contributor

Proposed changes

  • Update CICD

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@blukat29
Copy link
Contributor

@Sotatek-TinnNguyen Please open a PR for the 'dev' branch and rebase the change against the latest dev please. I need this fix on the dev branch first.

@Sotatek-TinnNguyen Sotatek-TinnNguyen changed the base branch from main to dev June 20, 2024 02:17
@Sotatek-TinnNguyen
Copy link
Contributor Author

@blukat29 can I merge this PR? I think this won't affect your code

@blukat29
Copy link
Contributor

@Sotatek-TinnNguyen Sure

@Sotatek-TinnNguyen Sotatek-TinnNguyen merged commit 1c2cc0e into dev Jun 20, 2024
7 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@blukat29 blukat29 deleted the update-cicd branch August 8, 2024 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants