Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Player selection missed in lastest releases and foreign chars in some places #404

Closed
Dikakus opened this issue Mar 28, 2024 · 4 comments · Fixed by #410
Closed

[Bug]: Player selection missed in lastest releases and foreign chars in some places #404

Dikakus opened this issue Mar 28, 2024 · 4 comments · Fixed by #410
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Dikakus
Copy link

Dikakus commented Mar 28, 2024

What happened?

In the latest releases, the player selector (in the lower left corner next to the play button) is missing. As a result, I can't switch between different players, and I don't know which one I'm currently using.

Snapshot from last stable release:
Airsonic-With-Player

On the other hand, non-English characters are displayed as html entities in some pages, such as the Spanish letter "ñ" in the Playlist page.

Snapshot from last edge release:
Airsonic-Tilde

Thank you.

Steps to reproduce

Accessing in the new release of Airsonic Advanced.

Version

11.1.x (Edge)

Version Detail

11.1.4-SNAPSHOT.20240325121919

Operating System

Linux, Debian Bookworm in a Raspberry Pi 4

Java Version

openjdk 17.0.10 2024-01-16

Database

Other

DB Detail

Build-in database

Configuration paramter

[Unit]
Description=Airsonic Media Server
After=local-fs.target remote-fs.target network.target var-airsonic.service
Requires=var-airsonic.service
Wants=var-airsonic.service

[Service]
Type=simple
ExecStartPre=/bin/sleep 30
Environment="JAVA_JAR=/srv/airsonic/airsonic.war"
##Environment="JAVA_OPTS=-Xmx2048m -XX:MaxPermSize=1024m"
Environment="JAVA_OPTS=-Xmx2048m"
Environment="AIRSONIC_HOME=/var/airsonic"
Environment="PORT=8085"
Environment="CONTEXT_PATH=/airsonic"
Environment="DEBUG_LEVEL=WARN"
Environment="JAVA_ARGS="
EnvironmentFile=-/etc/sysconfig/airsonic
ExecStart=/usr/bin/java
$JAVA_OPTS
-Dairsonic.home=${AIRSONIC_HOME}
-Dserver.forward-headers-strategy=native
-Dserver.servlet.context-path=${CONTEXT_PATH}
-Dserver.port=${PORT}
-Dlogging.level.org.airsonic=${DEBUG_LEVEL}
-jar ${JAVA_JAR} $JAVA_ARGS

User=airsonic
Group=airsonic

See https://www.freedesktop.org/software/systemd/man/systemd.exec.html

for details

DevicePolicy=closed
DeviceAllow=char-alsa rw
NoNewPrivileges=yes
PrivateTmp=false
PrivateUsers=yes
ProtectControlGroups=yes
ProtectKernelModules=yes
ProtectKernelTunables=yes
RestrictAddressFamilies=AF_UNIX AF_INET AF_INET6
RestrictNamespaces=yes
RestrictRealtime=yes
SystemCallFilter=@basic-io @File-system @chown @network-io @sync @Timer @signal @process @System-service
ReadWritePaths=/var/airsonic

You can uncomment the following line if you're not using the jukebox

This will prevent airsonic from accessing any real (physical) devices

#PrivateDevices=yes

You can change the following line to strict instead of full

if you don't want airsonic to be able to

write anything on your filesystem outside of AIRSONIC_HOME.

ProtectSystem=full

You can uncomment the following line if you don't have any media

in /home/…. This will prevent airsonic from ever reading/writing anything there.

#ProtectHome=true

You can uncomment the following line if you're not using the OpenJDK.

This will prevent processes from having a memory zone that is both writeable

and executeable, making hacker's lifes a bit harder.

#MemoryDenyWriteExecute=yes

[Install]
WantedBy=multi-user.target
WantedBy=var-airsonic.mount

Proxy Server

No response

client detail

No response

language

Spanish

Relevant log output

No response

@Dikakus Dikakus added the bug Something isn't working label Mar 28, 2024
@Dikakus Dikakus changed the title [Bug]: Player selection lost in lastest releases and foreign chars in some places [Bug]: Player selection missing in lastest releases and foreign chars in some places Mar 28, 2024
@Dikakus Dikakus changed the title [Bug]: Player selection missing in lastest releases and foreign chars in some places [Bug]: Player selection missed in lastest releases and foreign chars in some places Mar 28, 2024
@kagemomiji kagemomiji self-assigned this Apr 4, 2024
@kagemomiji kagemomiji added this to the 11.1.4 milestone Apr 4, 2024
@kagemomiji kagemomiji moved this from NoStatus to Todo in kagemomiji/airsonic-advanced project Apr 4, 2024
@kagemomiji kagemomiji moved this from Todo to In Progress in kagemomiji/airsonic-advanced project Apr 6, 2024
kagemomiji added a commit that referenced this issue Apr 7, 2024
@kagemomiji
Copy link
Owner

@Dikakus
I have created fixed war file. Could you please test this?

@Dikakus
Copy link
Author

Dikakus commented Apr 7, 2024

Hi, @kagemomiji !! Thank you so much!! The player selector has returned, and I can choose the player that I'm interested in:

image

I know that foreign chars are a different issue and maybe I should have opened another one. The "ñ" is now fine but there are other words with html entities (I've detected in the previous screenshoot and in the login page):

Login page:
image

This page works now:
image

Maybe I could lend you a hand reviewing these words if you tell me how I should do it.

@kagemomiji
Copy link
Owner

@Dikakus

Thank you so much!! The player selector has returned, and I can choose the player that I'm interested in:

Great! Thank you.

I know that foreign chars are a different issue and maybe I should have opened another one.

It's fine, it doesn't bother me.

I've made some further modifications. Could you please check if there are any mistakes?
fixed war file

@Dikakus
Copy link
Author

Dikakus commented Apr 8, 2024

Everything is perfect. I took a quick walk through some pages and all the text is fine now. Thanks again @kagemomiji for your work and effort. ^_^

kagemomiji added a commit that referenced this issue Apr 9, 2024
…-problem

#404 fix player selection problem and foreign char problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants