Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Replace DAO class with JPARepository due to SQL maintenance issues #212

Closed
15 of 17 tasks
kagemomiji opened this issue May 1, 2023 · 1 comment · Fixed by #342
Closed
15 of 17 tasks

[Feature Request]: Replace DAO class with JPARepository due to SQL maintenance issues #212

kagemomiji opened this issue May 1, 2023 · 1 comment · Fixed by #342
Assignees
@kagemomiji
Labels
enhancement New feature or request refactor
Milestone
11.1.3

Comments

@kagemomiji
Copy link
Owner

kagemomiji commented May 1, 2023 •
edited
Loading

Scope

Other

What problem

The current implementation uses DAO classes to handle SQL queries, which can be difficult to maintain over time. DAO classes require developers to write raw SQL queries, which can lead to issues with readability and maintainability.

Feature

To address these issues, I recommend replacing DAO classes with JPARepository. JPARepository is a higher-level abstraction layer that eliminates the need to write raw SQL queries. This approach is more developer-friendly and easier to maintain over time. By using JPARepository, developers can focus on writing clean, readable code that is easy to maintain, rather than spending time on low-level SQL queries.

Overall, by replacing DAO classes with JPARepository, we can improve the maintainability of our codebase and reduce development time and costs.

  • AlbumDao.java
  • ArtistDao.java
  • AvatarDao.java
  • CoverArtDao.java
  • DatabaseDao.java
  • InternetRadioDao.java
  • MediaFileDao.java
  • MusicFolderDao.java
  • PlayerDao.java
  • PlaylistDao.java
  • PlayQueueDao.java
  • PodcastDao.java
  • RatingDao.java
  • ShareDao.java
  • SonosLinkDao.java
  • TranscodingDao.java
  • UserDao.java
@kagemomiji kagemomiji added the enhancement New feature or request label May 1, 2023
@kagemomiji kagemomiji added this to the 11.1.3 milestone May 1, 2023
@kagemomiji kagemomiji self-assigned this May 1, 2023
@kagemomiji kagemomiji moved this from NoStatus to Todo in kagemomiji/airsonic-advanced project May 1, 2023
kagemomiji added a commit that referenced this issue Aug 7, 2023
@kagemomiji
#212 implement UserRatingRepository
cc82bbe
@kagemomiji kagemomiji mentioned this issue Aug 7, 2023
Merged
kagemomiji added a commit that referenced this issue Aug 8, 2023
@kagemomiji
#212 update ignoredUsedUndeclaredDependency list
386346d
kagemomiji added a commit that referenced this issue Aug 8, 2023
@kagemomiji
#212 change music folder teardown process
81fc6c5
kagemomiji added a commit that referenced this issue Aug 8, 2023
@kagemomiji
Merge pull request #261 from kagemomiji/issue212-replace-rating-dao
7508220 
#212 implement UserRatingRepository
kagemomiji added a commit that referenced this issue Aug 8, 2023
@kagemomiji
#212 implement ShareRepository to replace shareDao
f8ffea1
@kagemomiji kagemomiji mentioned this issue Aug 8, 2023
Merged
kagemomiji added a commit that referenced this issue Aug 9, 2023
@kagemomiji
#212 fix bug of share_file table persistent
f3f6e2a
kagemomiji added a commit that referenced this issue Aug 9, 2023
@kagemomiji
Merge pull request #262 from kagemomiji/issue212-replace-share-dao
9aafb85 
#212 implement ShareRepository to replace shareDao
@kagemomiji kagemomiji moved this from Todo to In Progress in kagemomiji/airsonic-advanced project Aug 9, 2023
kagemomiji added a commit that referenced this issue Aug 19, 2023
@kagemomiji
#212 implement repository for CoverArt
4fbe13d
@kagemomiji kagemomiji mentioned this issue Aug 19, 2023
Merged
kagemomiji added a commit that referenced this issue Aug 19, 2023
@kagemomiji
Merge pull request #266 from kagemomiji/issue212-implement-cover-art-…
e3d7631 
…repository

#212 implement repository for CoverArt
kagemomiji added a commit that referenced this issue Aug 21, 2023
@kagemomiji
#212 implement repository for transcoding
eee9f43
@kagemomiji kagemomiji mentioned this issue Aug 21, 2023
Merged
kagemomiji added a commit that referenced this issue Aug 21, 2023
@kagemomiji
Merge pull request #268 from kagemomiji/issue212-transcoding-repository
560d655 
#212 implement repository for transcoding
kagemomiji added a commit that referenced this issue Aug 25, 2023
@kagemomiji
#212 implemented repository for artist
cb23ebb
@kagemomiji kagemomiji mentioned this issue Aug 25, 2023
Merged
kagemomiji added a commit that referenced this issue Aug 25, 2023
@kagemomiji
Merge pull request #269 from kagemomiji/issue212-implement-artist-rep…
1d76c91 
…ository

#212 implemented repository for artist
kagemomiji added a commit that referenced this issue Aug 29, 2023
@kagemomiji
#212 implement avatar repository for replaement of avatardao
2864307
@kagemomiji kagemomiji mentioned this issue Aug 29, 2023
Merged
kagemomiji added a commit that referenced this issue Aug 29, 2023
@kagemomiji
Merge pull request #270 from kagemomiji/issue212-implement-avatar-rep…
9c59aea 
…ository

#212 implement avatar repository for replaement of avatardao
kagemomiji added a commit that referenced this issue Sep 3, 2023
@kagemomiji
#212 implement album repository to replace albumdao
8690da8
kagemomiji added a commit that referenced this issue Nov 26, 2023
@kagemomiji
#212 Add JsonIgnore annotation to MediaFile class
0405790
kagemomiji added a commit that referenced this issue Nov 26, 2023
@kagemomiji
#212 Fix import order in MediaFile.java
2fafb9d
kagemomiji added a commit that referenced this issue Nov 27, 2023
@kagemomiji
#212 change transaction management of getHighestRatedAlbums
80468a4
kagemomiji added a commit that referenced this issue Nov 27, 2023
@kagemomiji
#212 add rating calculation logic to
7d9d09e 
getHighestRatedAlbums method
@8bitbuddhist
Copy link

This is a huge undertaking and I respect the effort that you're putting into this project. Thank you for keeping Airsonic alive! ❤

kagemomiji added a commit that referenced this issue Nov 29, 2023
@kagemomiji
#212 remove transaction annotation from MediaScannerService
6d6a917
kagemomiji added a commit that referenced this issue Nov 29, 2023
@kagemomiji
#212 changed media file saving logic
5ba1c1d
kagemomiji added a commit that referenced this issue Nov 29, 2023
@kagemomiji
#212 Fix save method call in MediaFileServiceTest
7b1d5c4
kagemomiji added a commit that referenced this issue Nov 30, 2023
@kagemomiji
#212 add AsyncWebSocketClient to StatusService
2021515
kagemomiji added a commit that referenced this issue Nov 30, 2023
@kagemomiji
#212 Fix
e44a783 
findByFolderInAndMediaTypeAndArtistAndTitleAndPresentTrue
method in MediaFileRepository
kagemomiji added a commit that referenced this issue Nov 30, 2023
@kagemomiji
#212 Add transactional annotation to updateMediaFile
34f8ccc 
method
kagemomiji added a commit that referenced this issue Nov 30, 2023
@kagemomiji
#212 change retrieve mediafile methods in SearchServiceUtilities
2e2fc59
kagemomiji added a commit that referenced this issue Dec 1, 2023
@kagemomiji
#212 Refactor media file update logic
0406d1b
kagemomiji added a commit that referenced this issue Dec 1, 2023
@kagemomiji
#212 Remove Transactional annotation from
2ae99b5 
updateMediaFile method
kagemomiji added a commit that referenced this issue Dec 1, 2023
@kagemomiji
Revert "#212 Remove Transactional annotation from"
6aadfe3 
This reverts commit 2ae99b5.
kagemomiji added a commit that referenced this issue Dec 1, 2023
@kagemomiji
#212 Fix media file check needs update logic
d9fd95f
kagemomiji added a commit that referenced this issue Dec 1, 2023
@kagemomiji
#212 Fix needsUpdate logic in MediaFileService
bc69629
kagemomiji added a commit that referenced this issue Dec 2, 2023
@kagemomiji
#212 Refactor updateMediaFileByFile method to include
1b9999c 
file existence check
kagemomiji added a commit that referenced this issue Dec 2, 2023
@kagemomiji
#212 treat batch size in markPresent method
dae02c1
kagemomiji added a commit that referenced this issue Dec 3, 2023
@kagemomiji
#212 Fix parallelStream usage in MediaFileService
f11b408
kagemomiji added a commit that referenced this issue Dec 3, 2023
@kagemomiji
Merge pull request #319 from kagemomiji/issue212-media-file-repository
bdbad53 
#212 implemented MediaFileRepository to replace MediaFileDao
kagemomiji added a commit that referenced this issue Dec 6, 2023
@kagemomiji
#212 optimized podcasts channel deletion
bac3668
@kagemomiji kagemomiji mentioned this issue Dec 6, 2023
Merged
kagemomiji added a commit that referenced this issue Jan 2, 2024
@kagemomiji
#212 replaced PlayQueueDao to SavedPlayQueueRepository
7ee1110
kagemomiji added a commit that referenced this issue Jan 2, 2024
@kagemomiji
#212 removed AbstractDao
c521d89
@kagemomiji kagemomiji mentioned this issue Jan 2, 2024
Merged
thewriteway pushed a commit to thewriteway/airsonic-advanced that referenced this issue Jan 21, 2024
@kagemomiji @thewriteway
kagemomiji#212 optimized podcasts channel deletion
197b88d
kagemomiji added a commit that referenced this issue Jan 24, 2024
@kagemomiji
Merge pull request #342 from kagemomiji/issue212-play-queue-repository
c1f65da 
#212 Replace PlayQueueDao to Repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kagemomiji kagemomiji

Labels
enhancement New feature or request refactor
Projects
kagemomiji/airsonic-advanced project
Status: Done
Milestone
11.1.3
Development

Successfully merging a pull request may close this issue.

#212 Replace PlayQueueDao to Repository kagemomiji/airsonic-advanced
2 participants
@kagemomiji @8bitbuddhist