Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores() seems to behave differently on windows #54

Closed
alasdairhurst opened this issue Apr 16, 2019 · 1 comment
Closed

Ignores() seems to behave differently on windows #54

alasdairhurst opened this issue Apr 16, 2019 · 1 comment

Comments

@alasdairhurst
Copy link

alasdairhurst commented Apr 16, 2019

I notice you have a lot of similar issues related to windows paths. This one is specifically relative paths:

On unix, this throws an error.
cwd is /mnt/c/module

ignore.ignores('/mnt/c/module/package.json')

fatal error RangeError: path should be a `path.relative()`d string, but got "/mnt/c/module/package.json"

On windows it behaves differently. Possibly a false positive, but there's no error:

cwd is C:\module

ignore.ignores('C:\module\package.json')
kaelzhang added a commit that referenced this issue Apr 17, 2019
kaelzhang added a commit that referenced this issue Apr 17, 2019
Fixes a typo of an example
@kaelzhang
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants