Add custom condition effects to support the basic statuses the system has #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if the target of an attack is under the Sleep spell, this will now show Sleep as the source of advantage instead of Unconscious.
Added a helper function to the accumulator, fromConditions, to help with this. Also uses the similar strategy to get the condition effect keys that we do with Midi's keys
also fix bugs when there isn't a target
it is functionally the same, so just reuse the existing setting instead of making a new one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When v3.0 dropped, it added the basic D&D conditions and other statuses into the system, finally. Initial support was done in AR v3.4.0 by adding Midi-flags to the status effects. That works when applying the basic conditions but doesn't support other active effects that use the
statusesproperty (like some spells/features in the SRD do). This changes the implementation to remove those flags and directly handle advantage/disadvantage based on thosestatuses.